@@ -179,27 +179,27 @@ impl<'a> TargetFeatureFoldStrength<'a> {
179
179
180
180
pub ( crate ) struct LLVMFeature < ' a > {
181
181
llvm_feature_name : & ' a str ,
182
- dependency : Option < TargetFeatureFoldStrength < ' a > > ,
182
+ dependencies : Vec < TargetFeatureFoldStrength < ' a > > ,
183
183
}
184
184
185
185
impl < ' a > LLVMFeature < ' a > {
186
186
fn new ( llvm_feature_name : & ' a str ) -> Self {
187
- Self { llvm_feature_name, dependency : None }
187
+ Self { llvm_feature_name, dependencies : Vec :: new ( ) }
188
188
}
189
189
190
- fn with_dependency (
190
+ fn with_dependencies (
191
191
llvm_feature_name : & ' a str ,
192
- dependency : TargetFeatureFoldStrength < ' a > ,
192
+ dependencies : Vec < TargetFeatureFoldStrength < ' a > > ,
193
193
) -> Self {
194
- Self { llvm_feature_name, dependency : Some ( dependency ) }
194
+ Self { llvm_feature_name, dependencies : dependencies }
195
195
}
196
196
197
197
fn contains ( & self , feat : & str ) -> bool {
198
198
self . iter ( ) . any ( |dep| dep == feat)
199
199
}
200
200
201
201
fn iter ( & ' a self ) -> impl Iterator < Item = & ' a str > {
202
- let dependencies = self . dependency . iter ( ) . map ( |feat| feat. as_str ( ) ) ;
202
+ let dependencies = self . dependencies . iter ( ) . map ( |feat| feat. as_str ( ) ) ;
203
203
std:: iter:: once ( self . llvm_feature_name ) . chain ( dependencies)
204
204
}
205
205
}
@@ -209,7 +209,7 @@ impl<'a> IntoIterator for LLVMFeature<'a> {
209
209
type IntoIter = impl Iterator < Item = & ' a str > ;
210
210
211
211
fn into_iter ( self ) -> Self :: IntoIter {
212
- let dependencies = self . dependency . into_iter ( ) . map ( |feat| feat. as_str ( ) ) ;
212
+ let dependencies = self . dependencies . into_iter ( ) . map ( |feat| feat. as_str ( ) ) ;
213
213
std:: iter:: once ( self . llvm_feature_name ) . chain ( dependencies)
214
214
}
215
215
}
@@ -239,9 +239,9 @@ pub(crate) fn to_llvm_features<'a>(sess: &Session, s: &'a str) -> Option<LLVMFea
239
239
& * sess. target . arch
240
240
} ;
241
241
match ( arch, s) {
242
- ( "x86" , "sse4.2" ) => Some ( LLVMFeature :: with_dependency (
242
+ ( "x86" , "sse4.2" ) => Some ( LLVMFeature :: with_dependencies (
243
243
"sse4.2" ,
244
- TargetFeatureFoldStrength :: EnableOnly ( "crc32" ) ,
244
+ vec ! [ TargetFeatureFoldStrength :: EnableOnly ( "crc32" ) ] ,
245
245
) ) ,
246
246
( "x86" , "pclmulqdq" ) => Some ( LLVMFeature :: new ( "pclmul" ) ) ,
247
247
( "x86" , "rdrand" ) => Some ( LLVMFeature :: new ( "rdrnd" ) ) ,
@@ -262,7 +262,7 @@ pub(crate) fn to_llvm_features<'a>(sess: &Session, s: &'a str) -> Option<LLVMFea
262
262
( "aarch64" , "flagm2" ) => Some ( LLVMFeature :: new ( "altnzcv" ) ) ,
263
263
// Rust ties fp and neon together.
264
264
( "aarch64" , "neon" ) => {
265
- Some ( LLVMFeature :: with_dependency ( "neon" , TargetFeatureFoldStrength :: Both ( "fp-armv8" ) ) )
265
+ Some ( LLVMFeature :: with_dependencies ( "neon" , vec ! [ TargetFeatureFoldStrength :: Both ( "fp-armv8" ) ] ) )
266
266
}
267
267
// In LLVM neon implicitly enables fp, but we manually enable
268
268
// neon when a feature only implicitly enables fp
@@ -275,7 +275,7 @@ pub(crate) fn to_llvm_features<'a>(sess: &Session, s: &'a str) -> Option<LLVMFea
275
275
( "riscv32" | "riscv64" , "zacas" ) if get_version ( ) . 0 < 20 => None ,
276
276
// Enable the evex512 target feature if an avx512 target feature is enabled.
277
277
( "x86" , s) if s. starts_with ( "avx512" ) => {
278
- Some ( LLVMFeature :: with_dependency ( s, TargetFeatureFoldStrength :: EnableOnly ( "evex512" ) ) )
278
+ Some ( LLVMFeature :: with_dependencies ( s, vec ! [ TargetFeatureFoldStrength :: EnableOnly ( "evex512" ) ] ) )
279
279
}
280
280
// Support for `wide-arithmetic` will first land in LLVM 20 as part of
281
281
// llvm/llvm-project#111598
@@ -765,7 +765,7 @@ pub(crate) fn global_llvm_features(
765
765
"{}{}" ,
766
766
enable_disable, llvm_feature. llvm_feature_name
767
767
) )
768
- . chain ( llvm_feature. dependency . into_iter ( ) . filter_map (
768
+ . chain ( llvm_feature. dependencies . into_iter ( ) . filter_map (
769
769
move |feat| match ( enable, feat) {
770
770
( _, TargetFeatureFoldStrength :: Both ( f) )
771
771
| ( true , TargetFeatureFoldStrength :: EnableOnly ( f) ) => {
0 commit comments