Skip to content

Commit 3499da6

Browse files
author
Nicholas Matsakis
committed
Revert "Stabilize the never_type, written !."
This reverts commit 15c30dd.
1 parent bca33d7 commit 3499da6

File tree

19 files changed

+44
-23
lines changed

19 files changed

+44
-23
lines changed

src/libcore/clone.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -195,7 +195,7 @@ mod impls {
195195
bool char
196196
}
197197

198-
#[stable(feature = "never_type", since = "1.41.0")]
198+
#[unstable(feature = "never_type", issue = "35121")]
199199
impl Clone for ! {
200200
#[inline]
201201
fn clone(&self) -> Self {

src/libcore/cmp.rs

+4-4
Original file line numberDiff line numberDiff line change
@@ -1141,24 +1141,24 @@ mod impls {
11411141

11421142
ord_impl! { char usize u8 u16 u32 u64 u128 isize i8 i16 i32 i64 i128 }
11431143

1144-
#[stable(feature = "never_type", since = "1.41.0")]
1144+
#[unstable(feature = "never_type", issue = "35121")]
11451145
impl PartialEq for ! {
11461146
fn eq(&self, _: &!) -> bool {
11471147
*self
11481148
}
11491149
}
11501150

1151-
#[stable(feature = "never_type", since = "1.41.0")]
1151+
#[unstable(feature = "never_type", issue = "35121")]
11521152
impl Eq for ! {}
11531153

1154-
#[stable(feature = "never_type", since = "1.41.0")]
1154+
#[unstable(feature = "never_type", issue = "35121")]
11551155
impl PartialOrd for ! {
11561156
fn partial_cmp(&self, _: &!) -> Option<Ordering> {
11571157
*self
11581158
}
11591159
}
11601160

1161-
#[stable(feature = "never_type", since = "1.41.0")]
1161+
#[unstable(feature = "never_type", issue = "35121")]
11621162
impl Ord for ! {
11631163
fn cmp(&self, _: &!) -> Ordering {
11641164
*self

src/libcore/fmt/mod.rs

+2-2
Original file line numberDiff line numberDiff line change
@@ -1940,14 +1940,14 @@ macro_rules! fmt_refs {
19401940

19411941
fmt_refs! { Debug, Display, Octal, Binary, LowerHex, UpperHex, LowerExp, UpperExp }
19421942

1943-
#[stable(feature = "never_type", since = "1.41.0")]
1943+
#[unstable(feature = "never_type", issue = "35121")]
19441944
impl Debug for ! {
19451945
fn fmt(&self, _: &mut Formatter<'_>) -> Result {
19461946
*self
19471947
}
19481948
}
19491949

1950-
#[stable(feature = "never_type", since = "1.41.0")]
1950+
#[unstable(feature = "never_type", issue = "35121")]
19511951
impl Display for ! {
19521952
fn fmt(&self, _: &mut Formatter<'_>) -> Result {
19531953
*self

src/libcore/lib.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@
8787
#![feature(iter_once_with)]
8888
#![feature(lang_items)]
8989
#![feature(link_llvm_intrinsics)]
90-
#![cfg_attr(bootstrap, feature(never_type))]
90+
#![feature(never_type)]
9191
#![feature(nll)]
9292
#![feature(exhaustive_patterns)]
9393
#![feature(no_core)]

src/libcore/marker.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -774,7 +774,7 @@ mod copy_impls {
774774
bool char
775775
}
776776

777-
#[stable(feature = "never_type", since = "1.41.0")]
777+
#[unstable(feature = "never_type", issue = "35121")]
778778
impl Copy for ! {}
779779

780780
#[stable(feature = "rust1", since = "1.0.0")]

src/libcore/num/mod.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -4731,7 +4731,7 @@ impl From<Infallible> for TryFromIntError {
47314731
}
47324732
}
47334733

4734-
#[stable(feature = "never_type", since = "1.41.0")]
4734+
#[unstable(feature = "never_type", issue = "35121")]
47354735
impl From<!> for TryFromIntError {
47364736
fn from(never: !) -> TryFromIntError {
47374737
// Match rather than coerce to make sure that code like

src/librustc/lib.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737
#![feature(core_intrinsics)]
3838
#![feature(drain_filter)]
3939
#![cfg_attr(windows, feature(libc))]
40-
#![cfg_attr(bootstrap, feature(never_type))]
40+
#![feature(never_type)]
4141
#![feature(exhaustive_patterns)]
4242
#![feature(overlapping_marker_traits)]
4343
#![feature(extern_types)]

src/librustc_codegen_utils/lib.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
#![feature(box_patterns)]
99
#![feature(box_syntax)]
1010
#![feature(core_intrinsics)]
11-
#![cfg_attr(bootstrap, feature(never_type))]
11+
#![feature(never_type)]
1212
#![feature(nll)]
1313
#![feature(in_band_lifetimes)]
1414

src/librustc_error_codes/error_codes/E0725.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@ command line flags.
44
Erroneous code example:
55

66
```ignore (can't specify compiler flags from doctests)
7-
#![feature(specialization)] // error: the feature `specialization` is not in
8-
// the list of allowed features
7+
#![feature(never_type)] // error: the feature `never_type` is not in
8+
// the list of allowed features
99
```
1010

1111
Delete the offending feature attribute, or add it to the list of allowed

src/librustc_feature/accepted.rs

-2
Original file line numberDiff line numberDiff line change
@@ -253,8 +253,6 @@ declare_features! (
253253
(accepted, const_constructor, "1.40.0", Some(61456), None),
254254
/// Allows the use of `#[cfg(doctest)]`, set when rustdoc is collecting doctests.
255255
(accepted, cfg_doctest, "1.40.0", Some(62210), None),
256-
/// Allows the `!` type. Does not imply 'exhaustive_patterns' any more.
257-
(accepted, never_type, "1.41.0", Some(35121), None),
258256
/// Allows relaxing the coherence rules such that
259257
/// `impl<T> ForeignTrait<LocalType> for ForeignType<T>` is permitted.
260258
(accepted, re_rebalance_coherence, "1.41.0", Some(55437), None),

src/librustc_feature/active.rs

+3
Original file line numberDiff line numberDiff line change
@@ -307,6 +307,9 @@ declare_features! (
307307
/// Allows `X..Y` patterns.
308308
(active, exclusive_range_pattern, "1.11.0", Some(37854), None),
309309

310+
/// Allows the `!` type. Does not imply 'exhaustive_patterns' (below) any more.
311+
(active, never_type, "1.13.0", Some(35121), None),
312+
310313
/// Allows exhaustive pattern matching on types that contain uninhabited types.
311314
(active, exhaustive_patterns, "1.13.0", Some(51085), None),
312315

src/librustc_mir/lib.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ Rust MIR: a lowered representation of Rust. Also: an experiment!
1818
#![feature(drain_filter)]
1919
#![feature(exhaustive_patterns)]
2020
#![feature(iter_order_by)]
21-
#![cfg_attr(bootstrap, feature(never_type))]
21+
#![feature(never_type)]
2222
#![feature(specialization)]
2323
#![feature(try_trait)]
2424
#![feature(unicode_internals)]

src/librustc_typeck/lib.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ This API is completely unstable and subject to change.
6767
#![feature(in_band_lifetimes)]
6868
#![feature(nll)]
6969
#![feature(slice_patterns)]
70-
#![cfg_attr(bootstrap, feature(never_type))]
70+
#![feature(never_type)]
7171

7272
#![recursion_limit="256"]
7373

src/librustdoc/lib.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
#![feature(crate_visibility_modifier)]
1515
#![feature(const_fn)]
1616
#![feature(drain_filter)]
17-
#![cfg_attr(bootstrap, feature(never_type))]
17+
#![feature(never_type)]
1818
#![feature(unicode_internals)]
1919

2020
#![recursion_limit="256"]

src/libserialize/lib.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ Core encoding and decoding interfaces.
1111
#![feature(box_syntax)]
1212
#![feature(core_intrinsics)]
1313
#![feature(specialization)]
14-
#![cfg_attr(bootstrap, feature(never_type))]
14+
#![feature(never_type)]
1515
#![feature(nll)]
1616
#![feature(associated_type_bounds)]
1717
#![cfg_attr(test, feature(test))]

src/libstd/error.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -465,7 +465,7 @@ impl<'a> From<Cow<'a, str>> for Box<dyn Error> {
465465
}
466466
}
467467

468-
#[stable(feature = "never_type", since = "1.41.0")]
468+
#[unstable(feature = "never_type", issue = "35121")]
469469
impl Error for ! {
470470
fn description(&self) -> &str { *self }
471471
}

src/libstd/lib.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -281,7 +281,7 @@
281281
#![feature(maybe_uninit_ref)]
282282
#![feature(maybe_uninit_slice)]
283283
#![feature(needs_panic_runtime)]
284-
#![cfg_attr(bootstrap, feature(never_type))]
284+
#![feature(never_type)]
285285
#![feature(nll)]
286286
#![cfg_attr(bootstrap, feature(on_unimplemented))]
287287
#![feature(optin_builtin_traits)]

src/libstd/primitive_docs.rs

+3-1
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,7 @@ mod prim_bool { }
7171
/// write:
7272
///
7373
/// ```
74+
/// #![feature(never_type)]
7475
/// # fn foo() -> u32 {
7576
/// let x: ! = {
7677
/// return 123
@@ -200,6 +201,7 @@ mod prim_bool { }
200201
/// for example:
201202
///
202203
/// ```
204+
/// #![feature(never_type)]
203205
/// # use std::fmt;
204206
/// # trait Debug {
205207
/// # fn fmt(&self, formatter: &mut fmt::Formatter<'_>) -> fmt::Result;
@@ -237,7 +239,7 @@ mod prim_bool { }
237239
/// [`Default`]: default/trait.Default.html
238240
/// [`default()`]: default/trait.Default.html#tymethod.default
239241
///
240-
#[stable(feature = "never_type", since = "1.41.0")]
242+
#[unstable(feature = "never_type", issue = "35121")]
241243
mod prim_never { }
242244

243245
#[doc(primitive = "char")]

src/libsyntax/feature_gate/check.rs

+18
Original file line numberDiff line numberDiff line change
@@ -464,11 +464,25 @@ impl<'a> Visitor<'a> for PostExpansionVisitor<'a> {
464464
ast::TyKind::BareFn(ref bare_fn_ty) => {
465465
self.check_extern(bare_fn_ty.ext);
466466
}
467+
ast::TyKind::Never => {
468+
gate_feature_post!(&self, never_type, ty.span,
469+
"The `!` type is experimental");
470+
}
467471
_ => {}
468472
}
469473
visit::walk_ty(self, ty)
470474
}
471475

476+
fn visit_fn_ret_ty(&mut self, ret_ty: &'a ast::FunctionRetTy) {
477+
if let ast::FunctionRetTy::Ty(ref output_ty) = *ret_ty {
478+
if let ast::TyKind::Never = output_ty.kind {
479+
// Do nothing.
480+
} else {
481+
self.visit_ty(output_ty)
482+
}
483+
}
484+
}
485+
472486
fn visit_expr(&mut self, e: &'a ast::Expr) {
473487
match e.kind {
474488
ast::ExprKind::Box(_) => {
@@ -499,6 +513,10 @@ impl<'a> Visitor<'a> for PostExpansionVisitor<'a> {
499513
visit::walk_expr(self, e)
500514
}
501515

516+
fn visit_arm(&mut self, arm: &'a ast::Arm) {
517+
visit::walk_arm(self, arm)
518+
}
519+
502520
fn visit_pat(&mut self, pattern: &'a ast::Pat) {
503521
match &pattern.kind {
504522
PatKind::Slice(pats) => {

0 commit comments

Comments
 (0)