sanitizers: Stabilize AddressSanitizer and LeakSanitizer

Stabilize AddressSanitizer and LeakSanitizer for the Tier 1 targets that
support them.

Author: rcvalle

compiler/rustc_target/src/spec/targets/aarch64_unknown_linux_gnu.rs

@@ -19,12 +19,13 @@ pub(crate) fn target() -> Target {
             stack_probes: StackProbeType::Inline,
             supported_sanitizers: SanitizerSet::ADDRESS
                 | SanitizerSet::CFI
+                | SanitizerSet::HWADDRESS
                 | SanitizerSet::KCFI
                 | SanitizerSet::LEAK
                 | SanitizerSet::MEMORY
                 | SanitizerSet::MEMTAG
-                | SanitizerSet::THREAD
-                | SanitizerSet::HWADDRESS,
+                | SanitizerSet::THREAD,
+            stable_sanitizers: SanitizerSet::ADDRESS | SanitizerSet::LEAK,
             supports_xray: true,
             ..base::linux_gnu::opts()
         },

compiler/rustc_target/src/spec/targets/i686_pc_windows_msvc.rs

@@ -5,6 +5,7 @@ pub(crate) fn target() -> Target {
     base.cpu = "pentium4".into();
     base.max_atomic_width = Some(64);
     base.supported_sanitizers = SanitizerSet::ADDRESS;
+    base.stable_sanitizers = SanitizerSet::ADDRESS;
 
     base.add_pre_link_args(LinkerFlavor::Msvc(Lld::No), &[
         // Mark all dynamic libraries and executables as compatible with the larger 4GiB address

compiler/rustc_target/src/spec/targets/i686_unknown_linux_gnu.rs

@@ -5,6 +5,7 @@ pub(crate) fn target() -> Target {
     base.cpu = "pentium4".into();
     base.max_atomic_width = Some(64);
     base.supported_sanitizers = SanitizerSet::ADDRESS;
+    base.stable_sanitizers = SanitizerSet::ADDRESS;
     base.add_pre_link_args(LinkerFlavor::Gnu(Cc::Yes, Lld::No), &["-m32"]);
     base.stack_probes = StackProbeType::Inline;
 

compiler/rustc_target/src/spec/targets/x86_64_apple_darwin.rs

@@ -23,6 +23,7 @@ pub(crate) fn target() -> Target {
                 | SanitizerSet::CFI
                 | SanitizerSet::LEAK
                 | SanitizerSet::THREAD,
+            stable_sanitizers: SanitizerSet::ADDRESS | SanitizerSet::LEAK,
             ..opts
         },
     }

compiler/rustc_target/src/spec/targets/x86_64_pc_windows_msvc.rs

@@ -7,6 +7,7 @@ pub(crate) fn target() -> Target {
     base.plt_by_default = false;
     base.max_atomic_width = Some(128);
     base.supported_sanitizers = SanitizerSet::ADDRESS;
+    base.stable_sanitizers = SanitizerSet::ADDRESS;
 
     Target {
         llvm_target: "x86_64-pc-windows-msvc".into(),

compiler/rustc_target/src/spec/targets/x86_64_unknown_linux_gnu.rs

@@ -10,12 +10,13 @@ pub(crate) fn target() -> Target {
     base.static_position_independent_executables = true;
     base.supported_sanitizers = SanitizerSet::ADDRESS
         | SanitizerSet::CFI
-        | SanitizerSet::KCFI
         | SanitizerSet::DATAFLOW
+        | SanitizerSet::KCFI
         | SanitizerSet::LEAK
         | SanitizerSet::MEMORY
         | SanitizerSet::SAFESTACK
         | SanitizerSet::THREAD;
+    base.stable_sanitizers = SanitizerSet::ADDRESS | SanitizerSet::LEAK;
     base.supports_xray = true;
 
     // When we're asked to use the `rust-lld` linker by default, set the appropriate lld-using

tests/ui/sanitizer/stable-and-unstable-supported-can-be-used-with-unstable-options.rs

@@ -0,0 +1,11 @@
+// Verifies that stable and unstable supported sanitizers can be used with `-Zunstable-options`.
+//
+//@ needs-llvm-components: x86
+//@ needs-sanitizer-support
+//@ build-pass
+//@ compile-flags: -Zunstable-options -Clto -Csanitize=address,cfi --target x86_64-unknown-linux-gnu
+
+#![crate_type = "rlib"]
+#![feature(no_core)]
+#![no_core]
+#![no_main]

tests/ui/sanitizer/stable-and-unstable-supported-cannot-be-used-without-unstable-options.rs

@@ -0,0 +1,9 @@
+// Verifies that stable and unstable supported sanitizers cannot be used without
+// `-Zunstable-options`.
+//
+//@ needs-llvm-components: x86
+//@ needs-sanitizer-support
+//@ compile-flags: -Clto -Csanitize=address,cfi --target x86_64-unknown-linux-gnu
+//@ error-pattern: error: cfi sanitizer is not supported for this target
+
+fn main() { }

tests/ui/sanitizer/stable-and-unstable-supported-cannot-be-used-without-unstable-options.stderr

@@ -0,0 +1,4 @@
+error: cfi sanitizer is not supported for this target
+
+error: aborting due to 1 previous error
+

tests/ui/sanitizer/stable-supported-can-be-used-with-unstable-options.rs

@@ -0,0 +1,8 @@
+// Verifies that stable supported sanitizers can be used with `-Zunstable-options`.
+//
+//@ needs-llvm-components: x86
+//@ needs-sanitizer-support
+//@ build-pass
+//@ compile-flags: -Zunstable-options -Csanitize=address --target x86_64-unknown-linux-gnu
+
+fn main() { }

tests/ui/sanitizer/stable-supported-can-be-used-without-unstable-options.rs

@@ -0,0 +1,8 @@
+// Verifies that stable supported sanitizers can be used without `-Zunstable-options`.
+//
+//@ needs-llvm-components: x86
+//@ needs-sanitizer-support
+//@ build-pass
+//@ compile-flags: -Csanitize=address --target x86_64-unknown-linux-gnu
+
+fn main() { }