Skip to content

Commit 4851ec7

Browse files
authored
Rollup merge of #97826 - GuillaumeGomez:rustdoc-gui-tests-info, r=Dylan-DPC
Add more information for rustdoc-gui tests It was missing `--no-sandbox` in the `--help` message and the README was a bit outdated. cc `@jsha` (I recall you asking some questions about passing arguments to the rustdoc gui tester so here it). r? `@notriddle`
2 parents f12605b + 5799e7d commit 4851ec7

File tree

2 files changed

+16
-5
lines changed

2 files changed

+16
-5
lines changed

src/test/rustdoc-gui/README.md

+15-5
Original file line numberDiff line numberDiff line change
@@ -11,14 +11,24 @@ You can find more information and its documentation in its [repository][browser-
1111
If you need to have more information on the tests run, you can use `--test-args`:
1212

1313
```bash
14-
$ ./x.py test src/test/rustdoc-gui --stage 1 --jobs 8 --test-args --debug
14+
$ ./x.py test src/test/rustdoc-gui --stage 1 --test-args --debug
1515
```
1616

17-
There are three options supported:
17+
If you don't want to run in headless mode (helpful to debug sometimes), you can use
18+
`--no-headless`:
1819

19-
* `--debug`: allows to see puppeteer commands.
20-
* `--no-headless`: disable headless mode so you can see what's going on.
21-
* `--show-text`: by default, text isn't rendered because of issues with fonts, it enables it back.
20+
```bash
21+
$ ./x.py test src/test/rustdoc-gui --stage 1 --test-args --no-headless
22+
```
23+
24+
To see the supported options, use `--help`.
25+
26+
Important to be noted: if the chromium instance crashes when you run it, you might need to
27+
use `--no-sandbox` to make it work:
28+
29+
```bash
30+
$ ./x.py test src/test/rustdoc-gui --stage 1 --test-args --no-sandbox
31+
```
2232

2333
[browser-ui-test]: https://github.com/GuillaumeGomez/browser-UI-test/
2434
[puppeteer]: https://pptr.dev/

src/tools/rustdoc-gui/tester.js

+1
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ function showHelp() {
1616
console.log(" --debug : show extra information about script run");
1717
console.log(" --show-text : render font in pages");
1818
console.log(" --no-headless : disable headless mode");
19+
console.log(" --no-sandbox : disable sandbox mode");
1920
console.log(" --help : show this message then quit");
2021
console.log(" --tests-folder [PATH] : location of the .GOML tests folder");
2122
console.log(" --jobs [NUMBER] : number of threads to run tests on");

0 commit comments

Comments
 (0)