Skip to content

Commit 4b0f004

Browse files
committed
update inherent_impls tests
Now that we are visiting things in a different order during lowering, adding parameters winds up affecting the HirIds assigned to thinks in the method body, whereas it didn't before. We could fix this by reordering the order in which we visit `generics` during lowering, but this feels very fragile. Seems better to just let typeck tables be dirty here.
1 parent 60bff8c commit 4b0f004

File tree

1 file changed

+5
-6
lines changed

1 file changed

+5
-6
lines changed

src/test/incremental/hashes/inherent_impls.rs

+5-6
Original file line numberDiff line numberDiff line change
@@ -370,9 +370,7 @@ impl Foo {
370370
#[rustc_metadata_clean(cfg="cfail2")]
371371
#[rustc_metadata_clean(cfg="cfail3")]
372372
impl Foo {
373-
// FIXME(michaelwoerister): This is curious but an unused lifetime parameter doesn't seem to
374-
// show up in any of the derived data structures.
375-
#[rustc_clean(cfg="cfail2", except="Hir,HirBody")]
373+
#[rustc_clean(cfg="cfail2", except="Hir,HirBody,TypeckTables")]
376374
#[rustc_clean(cfg="cfail3")]
377375
#[rustc_metadata_clean(cfg="cfail2")]
378376
#[rustc_metadata_clean(cfg="cfail3")]
@@ -395,7 +393,7 @@ impl Foo {
395393
impl Foo {
396394
#[rustc_clean(
397395
cfg="cfail2",
398-
except="Hir,HirBody,GenericsOfItem,PredicatesOfItem,TypeOfItem",
396+
except="Hir,HirBody,GenericsOfItem,PredicatesOfItem,TypeOfItem,TypeckTables",
399397
)]
400398
#[rustc_clean(cfg="cfail3")]
401399
#[rustc_metadata_dirty(cfg="cfail2")]
@@ -441,7 +439,8 @@ impl Foo {
441439
#[rustc_metadata_clean(cfg="cfail2")]
442440
#[rustc_metadata_clean(cfg="cfail3")]
443441
impl Foo {
444-
#[rustc_clean(cfg="cfail2", except="Hir,HirBody,GenericsOfItem,PredicatesOfItem,TypeOfItem")]
442+
#[rustc_clean(cfg="cfail2", except="Hir,HirBody,GenericsOfItem,PredicatesOfItem,\
443+
TypeOfItem,TypeckTables")]
445444
#[rustc_clean(cfg="cfail3")]
446445
#[rustc_metadata_dirty(cfg="cfail2")]
447446
#[rustc_metadata_clean(cfg="cfail3")]
@@ -462,7 +461,7 @@ impl Foo {
462461
#[rustc_metadata_clean(cfg="cfail2")]
463462
#[rustc_metadata_clean(cfg="cfail3")]
464463
impl Foo {
465-
#[rustc_clean(cfg="cfail2", except="Hir,HirBody,PredicatesOfItem")]
464+
#[rustc_clean(cfg="cfail2", except="Hir,HirBody,PredicatesOfItem,TypeckTables")]
466465
#[rustc_clean(cfg="cfail3")]
467466
#[rustc_metadata_dirty(cfg="cfail2")]
468467
#[rustc_metadata_clean(cfg="cfail3")]

0 commit comments

Comments
 (0)