Added expect attribute tests (RFC 2383)

Author: xFrednet

src/test/ui/lint/rfc-2383-lint-reason/expect-consumes-all-warnings.rs

@@ -0,0 +1,21 @@
+// check-pass
+
+#![feature(lint_reasons)]
+
+#[expect(unused_variables, reason = "All emissions should be consumed by the nested expect")]
+//~^ WARNING this lint expectation is unfulfilled [unfulfilled_lint_expectation]
+//~| NOTE #[warn(unfulfilled_lint_expectation)]` on by default
+//~| NOTE All emissions should be consumed by the nested expect
+mod oof {
+    #[expect(unused_variables, reason = "This should collect all unused variable emissions")]
+    fn bar() {
+        let mut c = 0;
+        let mut l = 0;
+        let mut l = 0;
+        let mut i = 0;
+        let mut p = 0;
+        let mut y = 0;
+    }
+}
+
+fn main() {}

src/test/ui/lint/rfc-2383-lint-reason/expect-consumes-all-warnings.stderr

@@ -0,0 +1,11 @@
+warning: this lint expectation is unfulfilled
+  --> $DIR/expect-consumes-all-warnings.rs:5:1
+   |
+LL | #[expect(unused_variables, reason = "All emissions should be consumed by the nested expect")]
+   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+   |
+   = note: `#[warn(unfulfilled_lint_expectation)]` on by default
+   = note: All emissions should be consumed by the nested expect
+
+warning: 1 warning emitted
+

src/test/ui/lint/rfc-2383-lint-reason/expect_as_crate_attribute.rs

@@ -0,0 +1,8 @@
+// check-pass
+
+#![feature(lint_reasons)]
+
+#![expect(unused_mut)]
+//~^ WARNING this lint expectation is unfulfilled [unfulfilled_lint_expectation]
+
+fn main() {}

src/test/ui/lint/rfc-2383-lint-reason/expect_as_crate_attribute.stderr

@@ -0,0 +1,10 @@
+warning: this lint expectation is unfulfilled
+  --> $DIR/expect_as_crate_attribute.rs:5:1
+   |
+LL | #![expect(unused_mut)]
+   | ^^^^^^^^^^^^^^^^^^^^^^
+   |
+   = note: `#[warn(unfulfilled_lint_expectation)]` on by default
+
+warning: 1 warning emitted
+

src/test/ui/lint/rfc-2383-lint-reason/expect_reason.rs

@@ -0,0 +1,10 @@
+// check-pass
+
+#![feature(lint_reasons)]
+
+#![expect(unused_variables, reason = "<This should fail and display this reason>")]
+//~^ WARNING this lint expectation is unfulfilled [unfulfilled_lint_expectation]
+//~| NOTE `#[warn(unfulfilled_lint_expectation)]` on by default
+//~| NOTE <This should fail and display this reason>
+
+fn main() {}

src/test/ui/lint/rfc-2383-lint-reason/expect_reason.stderr

@@ -0,0 +1,11 @@
+warning: this lint expectation is unfulfilled
+  --> $DIR/expect_reason.rs:5:1
+   |
+LL | #![expect(unused_variables, reason = "<This should fail and display this reason>")]
+   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+   |
+   = note: `#[warn(unfulfilled_lint_expectation)]` on by default
+   = note: <This should fail and display this reason>
+
+warning: 1 warning emitted
+

src/test/ui/lint/rfc-2383-lint-reason/expect_with_nested_levels.rs

@@ -0,0 +1,29 @@
+// check-pass
+
+#![feature(lint_reasons)]
+
+#[expect(unused_mut, reason = "This should trigger because `unused_mut` was allow")]
+//~^ WARNING this lint expectation is unfulfilled [unfulfilled_lint_expectation]
+//~| NOTE `#[warn(unfulfilled_lint_expectation)]` on by default
+//~| NOTE This should trigger because `unused_mut` was allow
+mod foo {
+  fn bar() {
+    #[allow(unused_mut, reason = "v is unused")]
+    let mut v = 0;
+  }
+}
+
+#[expect(unused_mut, reason = "This should trigger because `unused_mut` is no longer expected")]
+//~^ WARNING this lint expectation is unfulfilled [unfulfilled_lint_expectation]
+//~| NOTE This should trigger because `unused_mut` is no longer expected
+mod oof {
+    #[warn(unused_mut, reason = "We no longer expect it in this scope")]
+    //~^ NOTE the lint level is defined here
+    fn bar() {
+        let mut v = 0;
+        //~^ WARNING variable does not need to be mutable [unused_mut]
+        //~| NOTE We no longer expect it in this scope
+    }
+}
+
+fn main() {}

src/test/ui/lint/rfc-2383-lint-reason/expect_with_nested_levels.stderr

@@ -0,0 +1,34 @@
+warning: variable does not need to be mutable
+  --> $DIR/expect_with_nested_levels.rs:23:13
+   |
+LL |         let mut v = 0;
+   |             ----^
+   |             |
+   |             help: remove this `mut`
+   |
+   = note: We no longer expect it in this scope
+note: the lint level is defined here
+  --> $DIR/expect_with_nested_levels.rs:20:12
+   |
+LL |     #[warn(unused_mut, reason = "We no longer expect it in this scope")]
+   |            ^^^^^^^^^^
+
+warning: this lint expectation is unfulfilled
+  --> $DIR/expect_with_nested_levels.rs:5:1
+   |
+LL | #[expect(unused_mut, reason = "This should trigger because `unused_mut` was allow")]
+   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+   |
+   = note: `#[warn(unfulfilled_lint_expectation)]` on by default
+   = note: This should trigger because `unused_mut` was allow
+
+warning: this lint expectation is unfulfilled
+  --> $DIR/expect_with_nested_levels.rs:16:1
+   |
+LL | #[expect(unused_mut, reason = "This should trigger because `unused_mut` is no longer expected")]
+   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+   |
+   = note: This should trigger because `unused_mut` is no longer expected
+
+warning: 3 warnings emitted
+

src/test/ui/lint/rfc-2383-lint-reason/expecting_missed_expectations.rs

@@ -0,0 +1,21 @@
+// check-pass
+
+#![feature(lint_reasons)]
+
+#[expect(unfulfilled_lint_expectation, reason = "this should catch the nested expect")]
+mod foo {
+  #[expect(unfulfilled_lint_expectation, reason = "issuing a lint and getting caught above")]
+  fn bar() {
+    #[expect(unused_mut, reason = "v is unused")]
+    let mut v = 0;
+  }
+}
+
+// make sure it doesn't catch itself
+#[expect(unfulfilled_lint_expectation, reason = "this should issue a warning")]
+//~^ WARNING this lint expectation is unfulfilled [unfulfilled_lint_expectation]
+//~| NOTE `#[warn(unfulfilled_lint_expectation)]` on by default
+//~| NOTE this should issue a warning
+mod oof {}
+
+fn main() {}

src/test/ui/lint/rfc-2383-lint-reason/expecting_missed_expectations.stderr

@@ -0,0 +1,11 @@
+warning: this lint expectation is unfulfilled
+  --> $DIR/expecting_missed_expectations.rs:15:1
+   |
+LL | #[expect(unfulfilled_lint_expectation, reason = "this should issue a warning")]
+   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+   |
+   = note: `#[warn(unfulfilled_lint_expectation)]` on by default
+   = note: this should issue a warning
+
+warning: 1 warning emitted
+

src/test/ui/lint/rfc-2383-lint-reason/invalid_expect_attribute.rs

@@ -0,0 +1,9 @@
+#![feature(lint_reasons)]
+
+#![expect(reason = "This should trigger because `unused_mut` was allow", unused_mut)]
+//~^ ERROR malformed lint attribute
+//~| ERROR malformed lint attribute
+//~| NOTE reason in lint attribute must come last
+//~| NOTE reason in lint attribute must come last
+
+fn main() {}

src/test/ui/lint/rfc-2383-lint-reason/invalid_expect_attribute.stderr

@@ -0,0 +1,15 @@
+error[E0452]: malformed lint attribute input
+  --> $DIR/invalid_expect_attribute.rs:3:11
+   |
+LL | #![expect(reason = "This should trigger because `unused_mut` was allow", unused_mut)]
+   |           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ reason in lint attribute must come last
+
+error[E0452]: malformed lint attribute input
+  --> $DIR/invalid_expect_attribute.rs:3:11
+   |
+LL | #![expect(reason = "This should trigger because `unused_mut` was allow", unused_mut)]
+   |           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ reason in lint attribute must come last
+
+error: aborting due to 2 previous errors
+
+For more information about this error, try `rustc --explain E0452`.

src/test/ui/lint/rfc-2383-lint-reason/multiple_expected_lints.rs

@@ -0,0 +1,8 @@
+// check-pass
+
+#![feature(lint_reasons)]
+
+#![expect(unconditional_panic, unused, reason = "Don't trigger because `unused` was triggered")]
+fn main() {
+    let x = 0;
+}

src/test/ui/lint/rfc-2383-lint-reason/tool_lint_in_expect.rs

@@ -0,0 +1,10 @@
+// check-pass
+
+#![feature(lint_reasons)]
+
+#![expect(
+    clippy::almost_swapped,
+    reason = "This should be ignored in a normal run but trigger in a clippy run")]
+fn main() {
+    // See lint doc https://rust-lang.github.io/rust-clippy/master/index.html#almost_swapped
+}

src/test/ui/lint/rfc-2383-lint-reason/unknown_lint_in_expect.rs

@@ -0,0 +1,7 @@
+// check-pass
+
+#![feature(lint_reasons)]
+
+#![expect(this_lint_does_not_exist)]
+//~^ WARNING unknown lint: `this_lint_does_not_exist` [unknown_lints]
+fn main() {}

src/test/ui/lint/rfc-2383-lint-reason/unknown_lint_in_expect.stderr

@@ -0,0 +1,10 @@
+warning: unknown lint: `this_lint_does_not_exist`
+  --> $DIR/unknown_lint_in_expect.rs:5:11
+   |
+LL | #![expect(this_lint_does_not_exist)]
+   |           ^^^^^^^^^^^^^^^^^^^^^^^^
+   |
+   = note: `#[warn(unknown_lints)]` on by default
+
+warning: 1 warning emitted
+