Skip to content

Commit 5ea47e1

Browse files
committed
add testcase for long expression
1 parent 41a7534 commit 5ea47e1

File tree

3 files changed

+36
-8
lines changed

3 files changed

+36
-8
lines changed

Diff for: tests/ui/lint/unused/closure-body-issue-136741.fixed

+14
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,15 @@
11
//@ run-rustfix
2+
// ignore-tidy-linelength
23
#![deny(unused_parens)]
34
#![deny(unused_braces)]
5+
6+
fn long_expr_that_does_not_require_braces_long_expr_that_does_not_require_braces_long_expr_that_does_not_require_braces()
7+
{}
8+
9+
fn func(f: impl FnOnce()) {
10+
f()
11+
}
12+
413
pub fn main() {
514
let _closure = |x: i32, y: i32| x * (x + (y * 2)); //~ ERROR unnecessary braces around closure body
615
let _ = || 0 == 0; //~ ERROR unnecessary parentheses around closure body
@@ -19,4 +28,9 @@ pub fn main() {
1928
_ = 0;
2029
0 == 0 //~ ERROR unnecessary parentheses around block return value
2130
};
31+
32+
// long expressions will not lint with braces
33+
func(|| {
34+
long_expr_that_does_not_require_braces_long_expr_that_does_not_require_braces_long_expr_that_does_not_require_braces()
35+
})
2236
}

Diff for: tests/ui/lint/unused/closure-body-issue-136741.rs

+14
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,15 @@
11
//@ run-rustfix
2+
// ignore-tidy-linelength
23
#![deny(unused_parens)]
34
#![deny(unused_braces)]
5+
6+
fn long_expr_that_does_not_require_braces_long_expr_that_does_not_require_braces_long_expr_that_does_not_require_braces()
7+
{}
8+
9+
fn func(f: impl FnOnce()) {
10+
f()
11+
}
12+
413
pub fn main() {
514
let _closure = |x: i32, y: i32| { x * (x + (y * 2)) }; //~ ERROR unnecessary braces around closure body
615
let _ = || (0 == 0); //~ ERROR unnecessary parentheses around closure body
@@ -21,4 +30,9 @@ pub fn main() {
2130
_ = 0;
2231
(0 == 0) //~ ERROR unnecessary parentheses around block return value
2332
};
33+
34+
// long expressions will not lint with braces
35+
func(|| {
36+
long_expr_that_does_not_require_braces_long_expr_that_does_not_require_braces_long_expr_that_does_not_require_braces()
37+
})
2438
}

Diff for: tests/ui/lint/unused/closure-body-issue-136741.stderr

+8-8
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
error: unnecessary braces around closure body
2-
--> $DIR/closure-body-issue-136741.rs:5:37
2+
--> $DIR/closure-body-issue-136741.rs:14:37
33
|
44
LL | let _closure = |x: i32, y: i32| { x * (x + (y * 2)) };
55
| ^^ ^^
66
|
77
note: the lint level is defined here
8-
--> $DIR/closure-body-issue-136741.rs:3:9
8+
--> $DIR/closure-body-issue-136741.rs:4:9
99
|
1010
LL | #![deny(unused_braces)]
1111
| ^^^^^^^^^^^^^
@@ -16,13 +16,13 @@ LL + let _closure = |x: i32, y: i32| x * (x + (y * 2));
1616
|
1717

1818
error: unnecessary parentheses around closure body
19-
--> $DIR/closure-body-issue-136741.rs:6:16
19+
--> $DIR/closure-body-issue-136741.rs:15:16
2020
|
2121
LL | let _ = || (0 == 0);
2222
| ^ ^
2323
|
2424
note: the lint level is defined here
25-
--> $DIR/closure-body-issue-136741.rs:2:9
25+
--> $DIR/closure-body-issue-136741.rs:3:9
2626
|
2727
LL | #![deny(unused_parens)]
2828
| ^^^^^^^^^^^^^
@@ -33,7 +33,7 @@ LL + let _ = || 0 == 0;
3333
|
3434

3535
error: unnecessary parentheses around closure body
36-
--> $DIR/closure-body-issue-136741.rs:7:28
36+
--> $DIR/closure-body-issue-136741.rs:16:28
3737
|
3838
LL | let _ = (0..).find(|n| (n % 2 == 0));
3939
| ^ ^
@@ -45,7 +45,7 @@ LL + let _ = (0..).find(|n| n % 2 == 0);
4545
|
4646

4747
error: unnecessary braces around closure body
48-
--> $DIR/closure-body-issue-136741.rs:8:28
48+
--> $DIR/closure-body-issue-136741.rs:17:28
4949
|
5050
LL | let _ = (0..).find(|n| {n % 2 == 0});
5151
| ^ ^
@@ -57,7 +57,7 @@ LL + let _ = (0..).find(|n| n % 2 == 0);
5757
|
5858

5959
error: unnecessary parentheses around closure body
60-
--> $DIR/closure-body-issue-136741.rs:16:28
60+
--> $DIR/closure-body-issue-136741.rs:25:28
6161
|
6262
LL | let _ = (0..).find(|n| (
6363
| _____________________________^
@@ -76,7 +76,7 @@ LL + let _ = (0..).find(|n| n % 2 == 0);
7676
|
7777

7878
error: unnecessary parentheses around block return value
79-
--> $DIR/closure-body-issue-136741.rs:22:9
79+
--> $DIR/closure-body-issue-136741.rs:31:9
8080
|
8181
LL | (0 == 0)
8282
| ^ ^

0 commit comments

Comments
 (0)