Skip to content

Commit 75a2131

Browse files
committed
BTreeMap: fix make tidy
1 parent 1daa225 commit 75a2131

File tree

3 files changed

+265
-66
lines changed

3 files changed

+265
-66
lines changed

src/libcollections/btree/map.rs

+41-10
Original file line numberDiff line numberDiff line change
@@ -114,13 +114,20 @@ impl<K: Clone, V: Clone> Clone for BTreeMap<K, V> {
114114
Ok(parent) => parent,
115115
Err(_) => break 'main
116116
};
117-
internal_out_node = internal_out_node.ascend().ok().unwrap().into_node();
117+
internal_out_node = internal_out_node.ascend()
118+
.ok()
119+
.unwrap()
120+
.into_node();
118121
}
119122
}
120123
}
121124

122125
let (k, v) = internal_kv.into_kv();
123-
internal_out_node.push(k.clone(), v.clone(), create_chain(internal_kv.into_node().height() - 1));
126+
internal_out_node.push(
127+
k.clone(),
128+
v.clone(),
129+
create_chain(internal_kv.into_node().height() - 1)
130+
);
124131

125132
in_node = first_leaf_edge(internal_kv.right_edge().descend()).into_node();
126133
out_node = first_leaf_edge(internal_out_node.last_edge().descend()).into_node();
@@ -236,7 +243,13 @@ pub struct VacantEntry<'a, K: 'a, V: 'a> {
236243
/// An occupied Entry.
237244
#[stable(feature = "rust1", since = "1.0.0")]
238245
pub struct OccupiedEntry<'a, K: 'a, V: 'a> {
239-
handle: Handle<NodeRef<marker::Borrowed<'a>, K, V, marker::Mut, marker::LeafOrInternal>, marker::KV>,
246+
handle: Handle<NodeRef<
247+
marker::Borrowed<'a>,
248+
K, V,
249+
marker::Mut,
250+
marker::LeafOrInternal
251+
>, marker::KV>,
252+
240253
length: &'a mut usize
241254
}
242255

@@ -681,7 +694,7 @@ impl<K, V> IntoIterator for BTreeMap<K, V> {
681694
let root2 = unsafe { ptr::read(&self.root).into_ref() };
682695
let len = self.length;
683696
mem::forget(self);
684-
697+
685698
IntoIter {
686699
front: first_leaf_edge(root1),
687700
back: last_leaf_edge(root2),
@@ -724,7 +737,9 @@ impl<K, V> Iterator for IntoIter<K, V> {
724737
self.front = kv.right_edge();
725738
return Some((k, v));
726739
},
727-
Err(last_edge) => unsafe { unwrap_unchecked(last_edge.into_node().deallocate_and_ascend()) }
740+
Err(last_edge) => unsafe {
741+
unwrap_unchecked(last_edge.into_node().deallocate_and_ascend())
742+
}
728743
};
729744

730745
loop {
@@ -764,7 +779,9 @@ impl<K, V> DoubleEndedIterator for IntoIter<K, V> {
764779
self.back = kv.left_edge();
765780
return Some((k, v));
766781
},
767-
Err(last_edge) => unsafe { unwrap_unchecked(last_edge.into_node().deallocate_and_ascend()) }
782+
Err(last_edge) => unsafe {
783+
unwrap_unchecked(last_edge.into_node().deallocate_and_ascend())
784+
}
768785
};
769786

770787
loop {
@@ -1109,7 +1126,12 @@ impl<'a, K: Ord, Q: ?Sized, V> Index<&'a Q> for BTreeMap<K, V>
11091126
}
11101127
}
11111128

1112-
fn first_leaf_edge<Lifetime, K, V, Mutability>(mut node: NodeRef<Lifetime, K, V, Mutability, marker::LeafOrInternal>) -> Handle<NodeRef<Lifetime, K, V, Mutability, marker::Leaf>, marker::Edge> {
1129+
fn first_leaf_edge<Lifetime, K, V, Mutability>(
1130+
mut node: NodeRef<Lifetime,
1131+
K, V,
1132+
Mutability,
1133+
marker::LeafOrInternal>
1134+
) -> Handle<NodeRef<Lifetime, K, V, Mutability, marker::Leaf>, marker::Edge> {
11131135
loop {
11141136
match node.force() {
11151137
Leaf(leaf) => return leaf.first_edge(),
@@ -1120,7 +1142,12 @@ fn first_leaf_edge<Lifetime, K, V, Mutability>(mut node: NodeRef<Lifetime, K, V,
11201142
}
11211143
}
11221144

1123-
fn last_leaf_edge<Lifetime, K, V, Mutability>(mut node: NodeRef<Lifetime, K, V, Mutability, marker::LeafOrInternal>) -> Handle<NodeRef<Lifetime, K, V, Mutability, marker::Leaf>, marker::Edge> {
1145+
fn last_leaf_edge<Lifetime, K, V, Mutability>(
1146+
mut node: NodeRef<Lifetime,
1147+
K, V,
1148+
Mutability,
1149+
marker::LeafOrInternal>
1150+
) -> Handle<NodeRef<Lifetime, K, V, Mutability, marker::Leaf>, marker::Edge> {
11241151
loop {
11251152
match node.force() {
11261153
Leaf(leaf) => return leaf.last_edge(),
@@ -1434,7 +1461,11 @@ enum UnderflowResult<'a, K, V> {
14341461
Stole(NodeRef<marker::Borrowed<'a>, K, V, marker::Mut, marker::Internal>)
14351462
}
14361463

1437-
fn handle_underfull_node<'a, K, V>(node: NodeRef<marker::Borrowed<'a>, K, V, marker::Mut, marker::LeafOrInternal>) -> UnderflowResult<'a, K, V> {
1464+
fn handle_underfull_node<'a, K, V>(node: NodeRef<marker::Borrowed<'a>,
1465+
K, V,
1466+
marker::Mut,
1467+
marker::LeafOrInternal>)
1468+
-> UnderflowResult<'a, K, V> {
14381469
let parent = if let Ok(parent) = node.ascend() {
14391470
parent
14401471
} else {
@@ -1464,7 +1495,7 @@ fn handle_underfull_node<'a, K, V>(node: NodeRef<marker::Borrowed<'a>, K, V, mar
14641495
let k = mem::replace(handle.reborrow_mut().into_kv_mut().0, k);
14651496
let v = mem::replace(handle.reborrow_mut().into_kv_mut().1, v);
14661497

1467-
// TODO: reuse cur_node?
1498+
// FIXME: reuse cur_node?
14681499
if is_left {
14691500
match handle.reborrow_mut().right_edge().descend().force() {
14701501
Leaf(mut leaf) => leaf.push_front(k, v),

0 commit comments

Comments
 (0)