Skip to content

Commit 8873e33

Browse files
committed
Don't --bless in pre-push hook
Running with --bless causes the push to succeed if there are fixable formatting changes, but the changes don't make it into the push. We should have the user rerun with --bless (or x.py fmt) and commit the changes themselves (they might want to amend a particular commit, for instance).
1 parent 03d488b commit 8873e33

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

Diff for: src/etc/pre-push.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ set -Eeuo pipefail
1010
# https://github.com/rust-lang/rust/issues/77620#issuecomment-705144570
1111
unset GIT_DIR
1212
ROOT_DIR="$(git rev-parse --show-toplevel)"
13-
COMMAND="$ROOT_DIR/x.py test tidy --bless"
13+
COMMAND="$ROOT_DIR/x.py test tidy"
1414

1515
if [[ "$OSTYPE" == "msys" || "$OSTYPE" == "win32" ]]; then
1616
COMMAND="python $COMMAND"

0 commit comments

Comments
 (0)