Fix null pointer dereference when a file is not an object file

bjorn3 · bjorn3 · commit 901c9daa05ec · 2024-08-14T19:37:14.000Z
diff --git a/compiler/rustc_llvm/llvm-wrapper/SymbolWrapper.cpp b/compiler/rustc_llvm/llvm-wrapper/SymbolWrapper.cpp
@@ -80,6 +80,9 @@ LLVMRustGetSymbols(char *BufPtr, size_t BufLen, void *State,
     return ErrorCallback(toString(ObjOrErr.takeError()).c_str());
   }
   std::unique_ptr<object::SymbolicFile> Obj = std::move(*ObjOrErr);
+  if (Obj == nullptr) {
+    return 0;
+  }
 
   for (const object::BasicSymbolRef &S : Obj->symbols()) {
     if (!isArchiveSymbol(S))

Original file line number	Diff line number	Diff line change
`@@ -80,6 +80,9 @@ LLVMRustGetSymbols(char BufPtr, size_t BufLen, void State,`
`80`	`80`	`return ErrorCallback(toString(ObjOrErr.takeError()).c_str());`
`81`	`81`	`}`
`82`	`82`	`std::unique_ptr<object::SymbolicFile> Obj = std::move(*ObjOrErr);`
	`83`	`+ if (Obj == nullptr) {`
	`84`	`+ return 0;`
	`85`	`+ }`
`83`	`86`
`84`	`87`	`for (const object::BasicSymbolRef &S : Obj->symbols()) {`
`85`	`88`	`if (!isArchiveSymbol(S))`