Skip to content

Commit 96c158b

Browse files
committed
Standardize mgca FIXMEs to "mgca"
1 parent 87fe433 commit 96c158b

File tree

5 files changed

+8
-8
lines changed

5 files changed

+8
-8
lines changed

compiler/rustc_ast_lowering/src/lib.rs

+2-2
Original file line numberDiff line numberDiff line change
@@ -2072,7 +2072,7 @@ impl<'a, 'hir> LoweringContext<'a, 'hir> {
20722072
path,
20732073
ParamMode::Optional,
20742074
AllowReturnTypeNotation::No,
2075-
// FIXME(min_generic_const_args): update for `fn foo() -> Bar<FOO<impl Trait>>` support
2075+
// FIXME(mgca): update for `fn foo() -> Bar<FOO<impl Trait>>` support
20762076
ImplTraitContext::Disallowed(ImplTraitPosition::Path),
20772077
None,
20782078
);
@@ -2147,7 +2147,7 @@ impl<'a, 'hir> LoweringContext<'a, 'hir> {
21472147
path,
21482148
ParamMode::Optional,
21492149
AllowReturnTypeNotation::No,
2150-
// FIXME(min_generic_const_args): update for `fn foo() -> Bar<FOO<impl Trait>>` support
2150+
// FIXME(mgca): update for `fn foo() -> Bar<FOO<impl Trait>>` support
21512151
ImplTraitContext::Disallowed(ImplTraitPosition::Path),
21522152
None,
21532153
);

compiler/rustc_hir_analysis/src/hir_ty_lowering/generics.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@ fn generic_arg_mismatch_err(
127127
body.value.kind
128128
&& let Res::Def(DefKind::Fn { .. }, id) = path.res
129129
{
130-
// FIXME(min_generic_const_args): this branch is dead once new const path lowering
130+
// FIXME(mgca): this branch is dead once new const path lowering
131131
// (for single-segment paths) is no longer gated
132132
err.help(format!("`{}` is a function item, not a type", tcx.item_name(id)));
133133
err.help("function item types cannot be named directly");

compiler/rustc_hir_analysis/src/hir_ty_lowering/mod.rs

+3-3
Original file line numberDiff line numberDiff line change
@@ -2232,7 +2232,7 @@ impl<'tcx> dyn HirTyLowerer<'tcx> + '_ {
22322232
let assoc_ident = assoc_segment.ident;
22332233

22342234
// Check if we have an enum variant or an inherent associated const.
2235-
// FIXME(min_generic_const_args): handle assoc fns once we support those
2235+
// FIXME(mgca): handle assoc fns once we support those
22362236
if let Some(adt_def) = self.probe_adt(span, qself_ty) {
22372237
if adt_def.is_enum() {
22382238
let variant_def = adt_def
@@ -2250,7 +2250,7 @@ impl<'tcx> dyn HirTyLowerer<'tcx> + '_ {
22502250
}
22512251
}
22522252

2253-
// FIXME(min_generic_const_args): Support self types other than ADTs.
2253+
// FIXME(mgca): Support self types other than ADTs.
22542254
let candidates = tcx
22552255
.inherent_impls(adt_def.did())
22562256
.iter()
@@ -2268,7 +2268,7 @@ impl<'tcx> dyn HirTyLowerer<'tcx> + '_ {
22682268
match &candidates[..] {
22692269
[] => {}
22702270
&[(impl_, assoc)] => {
2271-
// FIXME(min_generic_const_args): adapted from temporary inherent assoc ty code that may be incorrect
2271+
// FIXME(mgca): adapted from temporary inherent assoc ty code that may be incorrect
22722272
let parent_args = ty::GenericArgs::identity_for_item(tcx, impl_);
22732273
let args = self.lower_generic_args_of_assoc_item(
22742274
span,

compiler/rustc_hir_typeck/src/fn_ctxt/mod.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -340,7 +340,7 @@ impl<'tcx> HirTyLowerer<'tcx> for FnCtxt<'_, 'tcx> {
340340
) -> Const<'tcx> {
341341
let trait_ref = self.instantiate_binder_with_fresh_vars(
342342
span,
343-
// FIXME(min_generic_const_args): this should be assoc const not assoc type
343+
// FIXME(mgca): this should be assoc const not assoc type
344344
infer::BoundRegionConversionTime::AssocTypeProjection(item_def_id),
345345
poly_trait_ref,
346346
);

compiler/rustc_trait_selection/src/traits/select/confirmation.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -400,7 +400,7 @@ impl<'cx, 'tcx> SelectionContext<'cx, 'tcx> {
400400
let predicate = obligation.predicate.skip_binder();
401401

402402
let mut assume = predicate.trait_ref.args.const_at(2);
403-
// FIXME(min_generic_const_exprs): We should shallowly normalize this.
403+
// FIXME(mgca): We should shallowly normalize this.
404404
if self.tcx().features().generic_const_exprs() {
405405
assume = crate::traits::evaluate_const(self.infcx, assume, obligation.param_env)
406406
}

0 commit comments

Comments
 (0)