Skip to content

Commit 970fb61

Browse files
feat: Added capability to add multiple dependencies for an LLVMFeature
1 parent e5fefc3 commit 970fb61

File tree

1 file changed

+13
-12
lines changed

1 file changed

+13
-12
lines changed

compiler/rustc_codegen_llvm/src/llvm_util.rs

+13-12
Original file line numberDiff line numberDiff line change
@@ -179,27 +179,28 @@ impl<'a> TargetFeatureFoldStrength<'a> {
179179

180180
pub(crate) struct LLVMFeature<'a> {
181181
llvm_feature_name: &'a str,
182-
dependency: Option<TargetFeatureFoldStrength<'a>>,
182+
// dependency: Option<TargetFeatureFoldStrength<'a>>,
183+
dependencies: Vec<TargetFeatureFoldStrength<'a>>,
183184
}
184185

185186
impl<'a> LLVMFeature<'a> {
186187
fn new(llvm_feature_name: &'a str) -> Self {
187-
Self { llvm_feature_name, dependency: None }
188+
Self { llvm_feature_name, dependencies: Vec::new() }
188189
}
189190

190-
fn with_dependency(
191+
fn with_dependencies(
191192
llvm_feature_name: &'a str,
192-
dependency: TargetFeatureFoldStrength<'a>,
193+
dependencies: Vec<TargetFeatureFoldStrength<'a>>,
193194
) -> Self {
194-
Self { llvm_feature_name, dependency: Some(dependency) }
195+
Self { llvm_feature_name, dependencies: dependencies }
195196
}
196197

197198
fn contains(&self, feat: &str) -> bool {
198199
self.iter().any(|dep| dep == feat)
199200
}
200201

201202
fn iter(&'a self) -> impl Iterator<Item = &'a str> {
202-
let dependencies = self.dependency.iter().map(|feat| feat.as_str());
203+
let dependencies = self.dependencies.iter().map(|feat| feat.as_str());
203204
std::iter::once(self.llvm_feature_name).chain(dependencies)
204205
}
205206
}
@@ -209,7 +210,7 @@ impl<'a> IntoIterator for LLVMFeature<'a> {
209210
type IntoIter = impl Iterator<Item = &'a str>;
210211

211212
fn into_iter(self) -> Self::IntoIter {
212-
let dependencies = self.dependency.into_iter().map(|feat| feat.as_str());
213+
let dependencies = self.dependencies.into_iter().map(|feat| feat.as_str());
213214
std::iter::once(self.llvm_feature_name).chain(dependencies)
214215
}
215216
}
@@ -239,9 +240,9 @@ pub(crate) fn to_llvm_features<'a>(sess: &Session, s: &'a str) -> Option<LLVMFea
239240
&*sess.target.arch
240241
};
241242
match (arch, s) {
242-
("x86", "sse4.2") => Some(LLVMFeature::with_dependency(
243+
("x86", "sse4.2") => Some(LLVMFeature::with_dependencies(
243244
"sse4.2",
244-
TargetFeatureFoldStrength::EnableOnly("crc32"),
245+
vec![TargetFeatureFoldStrength::EnableOnly("crc32")],
245246
)),
246247
("x86", "pclmulqdq") => Some(LLVMFeature::new("pclmul")),
247248
("x86", "rdrand") => Some(LLVMFeature::new("rdrnd")),
@@ -262,7 +263,7 @@ pub(crate) fn to_llvm_features<'a>(sess: &Session, s: &'a str) -> Option<LLVMFea
262263
("aarch64", "flagm2") => Some(LLVMFeature::new("altnzcv")),
263264
// Rust ties fp and neon together.
264265
("aarch64", "neon") => {
265-
Some(LLVMFeature::with_dependency("neon", TargetFeatureFoldStrength::Both("fp-armv8")))
266+
Some(LLVMFeature::with_dependencies("neon", vec![TargetFeatureFoldStrength::Both("fp-armv8")]))
266267
}
267268
// In LLVM neon implicitly enables fp, but we manually enable
268269
// neon when a feature only implicitly enables fp
@@ -275,7 +276,7 @@ pub(crate) fn to_llvm_features<'a>(sess: &Session, s: &'a str) -> Option<LLVMFea
275276
("riscv32" | "riscv64", "zacas") if get_version().0 < 20 => None,
276277
// Enable the evex512 target feature if an avx512 target feature is enabled.
277278
("x86", s) if s.starts_with("avx512") => {
278-
Some(LLVMFeature::with_dependency(s, TargetFeatureFoldStrength::EnableOnly("evex512")))
279+
Some(LLVMFeature::with_dependencies(s, vec![TargetFeatureFoldStrength::EnableOnly("evex512")]))
279280
}
280281
// Support for `wide-arithmetic` will first land in LLVM 20 as part of
281282
// llvm/llvm-project#111598
@@ -765,7 +766,7 @@ pub(crate) fn global_llvm_features(
765766
"{}{}",
766767
enable_disable, llvm_feature.llvm_feature_name
767768
))
768-
.chain(llvm_feature.dependency.into_iter().filter_map(
769+
.chain(llvm_feature.dependencies.into_iter().filter_map(
769770
move |feat| match (enable, feat) {
770771
(_, TargetFeatureFoldStrength::Both(f))
771772
| (true, TargetFeatureFoldStrength::EnableOnly(f)) => {

0 commit comments

Comments
 (0)