Skip to content

Commit 986c168

Browse files
committed
Remove duplicate aliases for codegen_{cranelift,gcc}
Bootstrap already allows selecting these in `PathSet::has`, which allows any string that matches the end of a full path. I found these by adding `assert!(path.exists())` in `StepDescription::paths`. I think ideally we wouldn't have any aliases that aren't paths, but I've held off on enforcing that here since it may be controversial, I'll open a separate PR.
1 parent 027a232 commit 986c168

File tree

1 file changed

+1
-6
lines changed

1 file changed

+1
-6
lines changed

src/bootstrap/check.rs

+1-6
Original file line numberDiff line numberDiff line change
@@ -243,12 +243,7 @@ impl Step for CodegenBackend {
243243
const DEFAULT: bool = true;
244244

245245
fn should_run(run: ShouldRun<'_>) -> ShouldRun<'_> {
246-
run.paths(&[
247-
"compiler/rustc_codegen_cranelift",
248-
"rustc_codegen_cranelift",
249-
"compiler/rustc_codegen_gcc",
250-
"rustc_codegen_gcc",
251-
])
246+
run.paths(&["compiler/rustc_codegen_cranelift", "compiler/rustc_codegen_gcc"])
252247
}
253248

254249
fn make_run(run: RunConfig<'_>) {

0 commit comments

Comments
 (0)