Rollup merge of #106392 - compiler-errors:new-trait-solver-overflow, r=lcnr

matthiaskrgr · web-flow · commit 9d1193310f5c · 2023-01-03T17:12:13.000+01:00
`has_overflow` only if value is *not* within limit

New solver forgot a not operator, I think.
diff --git a/compiler/rustc_trait_selection/src/solve/overflow.rs b/compiler/rustc_trait_selection/src/solve/overflow.rs
@@ -36,7 +36,7 @@ impl OverflowData {
 
     #[inline]
     pub(super) fn has_overflow(&self, depth: usize) -> bool {
-        self.current_limit.value_within_limit(depth + self.additional_depth)
+        !self.current_limit.value_within_limit(depth + self.additional_depth)
     }
 
     /// Updating the current limit when hitting overflow.

Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,7 @@ impl OverflowData {`
`36`	`36`
`37`	`37`	`#[inline]`
`38`	`38`	`pub(super) fn has_overflow(&self, depth: usize) -> bool {`
`39`		`- self.current_limit.value_within_limit(depth + self.additional_depth)`
	`39`	`+ !self.current_limit.value_within_limit(depth + self.additional_depth)`
`40`	`40`	`}`
`41`	`41`
`42`	`42`	`/// Updating the current limit when hitting overflow.`