Skip to content

Commit aa67d1a

Browse files
committed
Specify the behavior of file!
This takes the current behavior of `file!` and documents it so it is safe to make assumptions about. For example, Cargo could provide a `CARGO_RUSTC_CURRENT_DIR` as a base path for `file!`. Example use cases - Being able to look up test assets relative to the current file ([example](https://github.com/rust-lang/cargo/blob/b9026bf654d7fac283465e58b8b76742244ef07d/tests/testsuite/cargo_add/add_basic/mod.rs#L34)) - Inline snapshotting libraries being able to update Rust source code ([example](https://github.com/rust-lang/cargo/blob/b9026bf654d7fac283465e58b8b76742244ef07d/tests/testsuite/alt_registry.rs#L36-L45)) See rust-lang/cargo#3946 for more context. T-libs-api discussed two solutions in rust-lang/libs-team#478 - `file_absolute!`: - Has less meaning in other build tools like buck2 - Bakes in the assumption that a full path is available (e.g. with trim-paths) - Specifying `file!`s behavior (this PR): - Leaves it to the user to deal with trim-paths - Even though `file!` is currently unspecified, changing it would likely have too large of an impact on the ecosystem at this time. A future possibility is that rustc could have a flag that controls modifies the base path used for `file!`. That seems purely additive with specifying the behavior and we do not want to block on it. It would also likely be too disruptive for Cargo users (as mentioned). However, we tried to keep this in mind when specifying the behavior.
1 parent a00df61 commit aa67d1a

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

library/core/src/macros/mod.rs

+6
Original file line numberDiff line numberDiff line change
@@ -1295,6 +1295,12 @@ pub(crate) mod builtin {
12951295
/// first macro invocation leading up to the invocation of the `file!`
12961296
/// macro.
12971297
///
1298+
/// The file name is derived from the source path passed to the Rust compiler and any path operations
1299+
/// performed on top of that (e.g. `#[path = "<child>"]` is joined to the current `file!`),
1300+
/// modified by any flags passed to the Rust compiler (e.g. `--remap-path-prefix`).
1301+
/// If the source path is relative,
1302+
/// the initial base directory will be the working directory of the Rust compiler.
1303+
///
12981304
/// # Examples
12991305
///
13001306
/// ```

0 commit comments

Comments
 (0)