Fix formatting and add more docs for bstr

Author: TimTheBig

library/alloc/src/bstr.rs

@@ -231,7 +231,7 @@ impl Default for ByteString {
 
 #[unstable(feature = "bstr", issue = "134915")]
 impl From<ByteString> for Vec<u8> {
-    /// Return the inner `Vec` of the byte string
+    /// Return the inner `Vec` of the byte string.
     #[inline]
     fn from(s: ByteString) -> Self {
         s.0
@@ -265,6 +265,10 @@ impl From<ByteString> for Vec<u8> {
 #[cfg(not(test))] // https://github.com/rust-lang/rust/issues/135100
 #[unstable(feature = "bstr", issue = "134915")]
 impl<'a> From<&'a ByteStr> for ByteString {
+    /// Convert the `ByteStr` to a `Vec` then wrap it in a `ByteString`.
+    ///
+    /// ## Cost
+    /// Allocates a new `Vec`
     #[inline]
     fn from(s: &'a ByteStr) -> Self {
         ByteString(s.0.to_vec())
@@ -274,6 +278,7 @@ impl<'a> From<&'a ByteStr> for ByteString {
 #[cfg(not(test))] // https://github.com/rust-lang/rust/issues/135100
 #[unstable(feature = "bstr", issue = "134915")]
 impl<'a> From<ByteString> for Cow<'a, ByteStr> {
+    /// Wrap `ByteString` in `Cow::Owned`.
     #[inline]
     fn from(s: ByteString) -> Self {
         Cow::Owned(s)
@@ -283,6 +288,7 @@ impl<'a> From<ByteString> for Cow<'a, ByteStr> {
 #[cfg(not(test))] // https://github.com/rust-lang/rust/issues/135100
 #[unstable(feature = "bstr", issue = "134915")]
 impl<'a> From<&'a ByteString> for Cow<'a, ByteStr> {
+    /// Wrap `ByteString` as byte str in `Cow::Borrowed`.
     #[inline]
     fn from(s: &'a ByteString) -> Self {
         Cow::Borrowed(s.as_bytestr())
@@ -636,7 +642,7 @@ impl Clone for Box<ByteStr> {
 #[cfg(not(test))] // https://github.com/rust-lang/rust/issues/135100
 #[unstable(feature = "bstr", issue = "134915")]
 impl<'a> From<&'a ByteStr> for Cow<'a, ByteStr> {
-    /// Create a `Borrowed` cow from a `ByteStr`
+    /// Create a `Borrowed` cow from a `ByteStr`.
     #[inline]
     fn from(s: &'a ByteStr) -> Self {
         Cow::Borrowed(s)
@@ -646,7 +652,7 @@ impl<'a> From<&'a ByteStr> for Cow<'a, ByteStr> {
 #[cfg(not(test))] // https://github.com/rust-lang/rust/issues/135100
 #[unstable(feature = "bstr", issue = "134915")]
 impl From<Box<[u8]>> for Box<ByteStr> {
-    /// Create a `Box<[u8]>` from `Box<ByteStr>`s raw
+    /// Create a `Box<[u8]>` from `Box<ByteStr>`s raw.
     #[inline]
     fn from(s: Box<[u8]>) -> Box<ByteStr> {
         // SAFETY: `ByteStr` is a transparent wrapper around `[u8]`.
@@ -657,7 +663,7 @@ impl From<Box<[u8]>> for Box<ByteStr> {
 #[cfg(not(test))] // https://github.com/rust-lang/rust/issues/135100
 #[unstable(feature = "bstr", issue = "134915")]
 impl From<Box<ByteStr>> for Box<[u8]> {
-    /// Create a `Box<ByteStr>` from `Box<[u8]>`s raw
+    /// Create a `Box<ByteStr>` from `Box<[u8]>`s raw.
     #[inline]
     fn from(s: Box<ByteStr>) -> Box<[u8]> {
         // SAFETY: `ByteStr` is a transparent wrapper around `[u8]`.
@@ -668,7 +674,7 @@ impl From<Box<ByteStr>> for Box<[u8]> {
 #[unstable(feature = "bstr", issue = "134915")]
 #[cfg(not(no_rc))]
 impl From<Rc<[u8]>> for Rc<ByteStr> {
-    /// Create a `Rc<[u8]>` from `Rc<ByteStr>`s raw
+    /// Create a `Rc<[u8]>` from `Rc<ByteStr>`s raw.
     #[inline]
     fn from(s: Rc<[u8]>) -> Rc<ByteStr> {
         // SAFETY: `ByteStr` is a transparent wrapper around `[u8]`.
@@ -679,7 +685,7 @@ impl From<Rc<[u8]>> for Rc<ByteStr> {
 #[unstable(feature = "bstr", issue = "134915")]
 #[cfg(not(no_rc))]
 impl From<Rc<ByteStr>> for Rc<[u8]> {
-    /// Create a `Rc<ByteStr>` from `Rc<[u8]>`s raw
+    /// Create a `Rc<ByteStr>` from `Rc<[u8]>`s raw.
     #[inline]
     fn from(s: Rc<ByteStr>) -> Rc<[u8]> {
         // SAFETY: `ByteStr` is a transparent wrapper around `[u8]`.
@@ -690,7 +696,7 @@ impl From<Rc<ByteStr>> for Rc<[u8]> {
 #[unstable(feature = "bstr", issue = "134915")]
 #[cfg(all(not(no_rc), not(no_sync), target_has_atomic = "ptr"))]
 impl From<Arc<[u8]>> for Arc<ByteStr> {
-    /// Create a `Arc<ByteStr>` from `Arc<[u8]>`s raw
+    /// Create a `Arc<ByteStr>` from `Arc<[u8]>`s raw.
     #[inline]
     fn from(s: Arc<[u8]>) -> Arc<ByteStr> {
         // SAFETY: `ByteStr` is a transparent wrapper around `[u8]`.
@@ -701,7 +707,7 @@ impl From<Arc<[u8]>> for Arc<ByteStr> {
 #[unstable(feature = "bstr", issue = "134915")]
 #[cfg(all(not(no_rc), not(no_sync), target_has_atomic = "ptr"))]
 impl From<Arc<ByteStr>> for Arc<[u8]> {
-    /// Create a `Arc<ByteStr>` from `Arc<[u8]>`s raw
+    /// Create a `Arc<ByteStr>` from `Arc<[u8]>`s raw.
     #[inline]
     fn from(s: Arc<ByteStr>) -> Arc<[u8]> {
         // SAFETY: `ByteStr` is a transparent wrapper around `[u8]`.
@@ -722,7 +728,7 @@ impl<'a> TryFrom<&'a ByteStr> for String {
     type Error = core::str::Utf8Error;
 
     /// Convert `ByteStr`s bytes to a utf-8 `String`.
-    /// 
+    ///
     /// # Errors
     /// If `ByteStr` is not valid utf-8
     #[inline]

library/std/src/sys/pal/windows/fs.rs

@@ -1070,7 +1070,7 @@ impl FileAttr {
     }
 }
 impl From<c::WIN32_FIND_DATAW> for FileAttr {
-    /// Map `c::WIN32_FIND_DATAW`s fields to a `FileAttr`, 
+    /// Map `c::WIN32_FIND_DATAW`s fields to a `FileAttr`,
     /// with some conditionals for `file_size` and `reparse_tag`.
     fn from(wfd: c::WIN32_FIND_DATAW) -> Self {
         FileAttr {