Skip to content

Commit db6cbfc

Browse files
committed
tidy: add new exceptions and remove std from skip list
Also doing fmt inplace as requested.
1 parent 022e1fe commit db6cbfc

File tree

2 files changed

+14
-5
lines changed

2 files changed

+14
-5
lines changed

src/tools/tidy/src/pal.rs

+5
Original file line numberDiff line numberDiff line change
@@ -56,9 +56,14 @@ const EXCEPTION_PATHS: &[&str] = &[
5656
// Integration test for platform-specific run-time feature detection:
5757
"library/std/tests/run-time-detect.rs",
5858
"library/std/src/net/test.rs",
59+
"library/std/src/net/addr",
60+
"library/std/src/net/udp",
5961
"library/std/src/sys_common/mod.rs",
6062
"library/std/src/sys_common/net.rs",
6163
"library/std/src/sys_common/backtrace.rs",
64+
"library/std/src/sys_common/remutex.rs",
65+
"library/std/src/sync/mutex.rs",
66+
"library/std/src/sync/rwlock.rs",
6267
// panic_unwind shims
6368
"library/std/src/panicking.rs",
6469
"library/term", // Not sure how to make this crate portable, but test crate needs it.

src/tools/tidy/src/unit_tests.rs

+9-5
Original file line numberDiff line numberDiff line change
@@ -20,15 +20,19 @@ pub fn check(root_path: &Path, bad: &mut bool) {
2020
let mut skip = |path: &Path| {
2121
let file_name = path.file_name().unwrap_or_default();
2222
if path.is_dir() {
23-
super::filter_dirs(path) ||
24-
path.ends_with("src/test") ||
25-
path.ends_with("src/doc") ||
26-
path.ends_with("library/std") || // FIXME?
27-
(file_name == "tests" || file_name == "benches") && !is_core(path)
23+
super::filter_dirs(path)
24+
|| path.ends_with("src/test")
25+
|| path.ends_with("src/doc")
26+
|| (file_name == "tests" || file_name == "benches") && !is_core(path)
2827
} else {
2928
let extension = path.extension().unwrap_or_default();
3029
extension != "rs"
3130
|| (file_name == "tests.rs" || file_name == "benches.rs") && !is_core(path)
31+
// UI tests with different names
32+
|| path.ends_with("src/thread/local/dynamic_tests.rs")
33+
|| path.ends_with("src/sync/mpsc/sync_tests.rs")
34+
// Has copyright banner
35+
|| path.ends_with("src/sys/cloudabi/abi/cloudabi.rs")
3236
}
3337
};
3438

0 commit comments

Comments
 (0)