avoid holding the temp_dir for empty metadata file

m-ysk · m-ysk · commit ea0e0f4e13a5 · 2022-07-02T22:54:37.000+09:00
diff --git a/compiler/rustc_metadata/src/rmeta/encoder.rs b/compiler/rustc_metadata/src/rmeta/encoder.rs
@@ -2158,7 +2158,7 @@ impl EncodedMetadata {
         let file = std::fs::File::open(&path)?;
         let file_metadata = file.metadata()?;
         if file_metadata.len() == 0 {
-            return Ok(Self { mmap: None, _temp_dir: temp_dir });
+            return Ok(Self { mmap: None, _temp_dir: None });
         }
         let mmap = unsafe { Some(Mmap::map(file)?) };
         Ok(Self { mmap, _temp_dir: temp_dir })

Original file line number	Diff line number	Diff line change
`@@ -2158,7 +2158,7 @@ impl EncodedMetadata {`
`2158`	`2158`	`let file = std::fs::File::open(&path)?;`
`2159`	`2159`	`let file_metadata = file.metadata()?;`
`2160`	`2160`	`if file_metadata.len() == 0 {`
`2161`		`- return Ok(Self { mmap: None, _temp_dir: temp_dir });`
	`2161`	`+ return Ok(Self { mmap: None, _temp_dir: None });`
`2162`	`2162`	`}`
`2163`	`2163`	`let mmap = unsafe { Some(Mmap::map(file)?) };`
`2164`	`2164`	`Ok(Self { mmap, _temp_dir: temp_dir })`