Skip to content

Commit ea8bd06

Browse files
authored
Rollup merge of #109444 - WaffleLapkin:undeprecate_todos, r=jyn514
Change tidy error message for TODOs Blocked on #109440 (first few commits are from where) IMO "deprecated" doesn't really explain anything, I've tried to highlight the actual reason we error on TODOs. The message is not at all perfect, maybe someone has ideas how to phrase it better?
2 parents 309496c + b311ec0 commit ea8bd06

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

src/tools/tidy/src/style.rs

+4-2
Original file line numberDiff line numberDiff line change
@@ -385,10 +385,12 @@ pub fn check(path: &Path, bad: &mut bool) {
385385
}
386386
if filename != "style.rs" {
387387
if trimmed.contains("TODO") {
388-
err("TODO is deprecated; use FIXME")
388+
err(
389+
"TODO is used for tasks that should be done before merging a PR; If you want to leave a message in the codebase use FIXME",
390+
)
389391
}
390392
if trimmed.contains("//") && trimmed.contains(" XXX") {
391-
err("XXX is deprecated; use FIXME")
393+
err("Instead of XXX use FIXME")
392394
}
393395
if any_problematic_line {
394396
for s in problematic_consts_strings.iter() {

0 commit comments

Comments
 (0)