Skip to content

Commit ed56c74

Browse files
committed
Specify the behavior of file!
This takes the current behavior of `file!` and documents it so it is safe to make assumptions about. For example, Cargo could provide a `CARGO_RUSTC_CURRENT_DIR` as a base path for `file!`. Example use cases - Being able to look up test assets relative to the current file ([example](https://github.com/rust-lang/cargo/blob/b9026bf654d7fac283465e58b8b76742244ef07d/tests/testsuite/cargo_add/add_basic/mod.rs#L34)) - Inline snapshotting libraries being able to update Rust source code ([example](https://github.com/rust-lang/cargo/blob/b9026bf654d7fac283465e58b8b76742244ef07d/tests/testsuite/alt_registry.rs#L36-L45)) See rust-lang/cargo#3946 for more context. T-libs-api discussed two solutions in rust-lang/libs-team#478 - `file_absolute!`: - Has less meaning in other build tools like buck2 - Bakes in the assumption that a full path is available (e.g. with trim-paths) - Specifying `file!`s behavior (this PR): - Leaves it to the user to deal with trim-paths - Even though `file!` is currently unspecified, changing it would likely have too large of an impact on the ecosystem at this time. A future possibility is that rustc could have a flag that controls modifies the base path used for `file!`. That seems purely additive with specifying the behavior and we do not want to block on it. It would also likely be too disruptive for Cargo users (as mentioned). However, we tried to keep this in mind when specifying the behavior.
1 parent a00df61 commit ed56c74

File tree

1 file changed

+13
-7
lines changed

1 file changed

+13
-7
lines changed

library/core/src/macros/mod.rs

+13-7
Original file line numberDiff line numberDiff line change
@@ -1287,13 +1287,19 @@ pub(crate) mod builtin {
12871287

12881288
/// Expands to the file name in which it was invoked.
12891289
///
1290-
/// With [`line!`] and [`column!`], these macros provide debugging information for
1291-
/// developers about the location within the source.
1292-
///
1293-
/// The expanded expression has type `&'static str`, and the returned file
1294-
/// is not the invocation of the `file!` macro itself, but rather the
1295-
/// first macro invocation leading up to the invocation of the `file!`
1296-
/// macro.
1290+
/// With [`line!`] and [`column!`], these macros provide debugging information for developers
1291+
/// about the location within the source.
1292+
///
1293+
/// The expanded expression has type `&'static str`, and the returned file is not the invocation
1294+
/// of the `file!` macro itself, but rather the first macro invocation leading up to the
1295+
/// invocation of the `file!` macro.
1296+
///
1297+
/// The file name is derived from the root module's source path passed to the Rust compiler
1298+
/// (e.g. `./src/lib.rs`) and the sequence the compiler takes to get from root module to the
1299+
/// module containing `file!` (e.g. inside `mod foo;` in `./src/lib.rs`, `file!` would be
1300+
/// `./src/foo.rs`), modified by any flags passed to the Rust compiler (e.g.
1301+
/// `--remap-path-prefix`). If the source path is relative, the initial base directory will be
1302+
/// the working directory of the Rust compiler.
12971303
///
12981304
/// # Examples
12991305
///

0 commit comments

Comments
 (0)