Skip to content

Commit f12d32d

Browse files
committed
Auto merge of #31389 - mitaa:schars, r=nrc
A span spanning only a single character would render like `^~` instead of just `^`. r? @nrc
2 parents 06fac82 + 1fcdedb commit f12d32d

File tree

1 file changed

+10
-10
lines changed

1 file changed

+10
-10
lines changed

src/libsyntax/errors/emitter.rs

+10-10
Original file line numberDiff line numberDiff line change
@@ -410,7 +410,7 @@ impl EmitterWriter {
410410
chars.next();
411411
}
412412
}
413-
if (col - col_ptr) > 1 {
413+
if (col - col_ptr) > 0 {
414414
// One extra squiggly is replaced by a "^"
415415
s.pop();
416416
}
@@ -962,7 +962,7 @@ mod test {
962962
_____\n\
963963
ddd__eee_\n\
964964
elided\n\
965-
_ff_gg";
965+
__f_gg";
966966
let file = cm.new_filemap_and_lines("dummy.txt", inp);
967967

968968
let span = |lo, hi, (off_lo, off_hi)| {
@@ -976,7 +976,7 @@ mod test {
976976
let sp1 = span(0, 6, (0, 5));
977977
let sp2 = span(8, 8, (0, 3));
978978
let sp3 = span(8, 8, (5, 8));
979-
let sp4 = span(10, 10, (1, 3));
979+
let sp4 = span(10, 10, (2, 3));
980980
let sp5 = span(10, 10, (4, 6));
981981

982982
let expect0 = "dummy.txt: 5 ccccc\n\
@@ -986,8 +986,8 @@ mod test {
986986
dummy.txt: 9 ddd__eee_\n\
987987
\x20 ^~~ ^~~\n\
988988
\x20 ...\n\
989-
dummy.txt:11 _ff_gg\n\
990-
\x20 ^~ ^~\n";
989+
dummy.txt:11 __f_gg\n\
990+
\x20 ^ ^~\n";
991991

992992
let expect = "dummy.txt: 1 aaaaa\n\
993993
dummy.txt: 2 aaaaa\n\
@@ -1008,8 +1008,8 @@ mod test {
10081008
let expect2 = "dummy.txt: 9 ddd__eee_\n\
10091009
\x20 ^~~ ^~~\n\
10101010
\x20 ...\n\
1011-
dummy.txt:11 _ff_gg\n\
1012-
\x20 ^~ ^~\n";
1011+
dummy.txt:11 __f_gg\n\
1012+
\x20 ^ ^~\n";
10131013

10141014

10151015
let expect_end = "dummy.txt: 1 aaaaa\n\
@@ -1020,7 +1020,7 @@ mod test {
10201020
dummy.txt: 9 ddd__eee_\n\
10211021
\x20 ^ ^\n\
10221022
\x20 ...\n\
1023-
dummy.txt:11 _ff_gg\n\
1023+
dummy.txt:11 __f_gg\n\
10241024
\x20 ^ ^\n";
10251025

10261026
let expect0_end = "dummy.txt: 5 ccccc\n\
@@ -1031,7 +1031,7 @@ mod test {
10311031
dummy.txt: 9 ddd__eee_\n\
10321032
\x20 ^ ^\n\
10331033
\x20 ...\n\
1034-
dummy.txt:11 _ff_gg\n\
1034+
dummy.txt:11 __f_gg\n\
10351035
\x20 ^ ^\n";
10361036

10371037
let expect_end_g1 = "dummy.txt:1 aaaaa\n\
@@ -1042,7 +1042,7 @@ mod test {
10421042
let expect2_end = "dummy.txt: 9 ddd__eee_\n\
10431043
\x20 ^ ^\n\
10441044
\x20 ...\n\
1045-
dummy.txt:11 _ff_gg\n\
1045+
dummy.txt:11 __f_gg\n\
10461046
\x20 ^ ^\n";
10471047

10481048
let expect_groups = [expect2, expect_g1];

0 commit comments

Comments
 (0)