Skip to content

Commit f68cd90

Browse files
committed
Remove Linkage::Appending
It can only be used for certain LLVM internal variables like llvm.global_ctors which users are not allowed to define.
1 parent 382e403 commit f68cd90

File tree

6 files changed

+0
-7
lines changed

6 files changed

+0
-7
lines changed

compiler/rustc_codegen_gcc/src/base.rs

-2
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,6 @@ pub fn global_linkage_to_gcc(linkage: Linkage) -> GlobalKind {
4949
Linkage::LinkOnceODR => unimplemented!(),
5050
Linkage::WeakAny => unimplemented!(),
5151
Linkage::WeakODR => unimplemented!(),
52-
Linkage::Appending => unimplemented!(),
5352
Linkage::Internal => GlobalKind::Internal,
5453
Linkage::ExternalWeak => GlobalKind::Imported, // TODO(antoyo): should be weak linkage.
5554
Linkage::Common => unimplemented!(),
@@ -65,7 +64,6 @@ pub fn linkage_to_gcc(linkage: Linkage) -> FunctionType {
6564
Linkage::LinkOnceODR => unimplemented!(),
6665
Linkage::WeakAny => FunctionType::Exported, // FIXME(antoyo): should be similar to linkonce.
6766
Linkage::WeakODR => unimplemented!(),
68-
Linkage::Appending => unimplemented!(),
6967
Linkage::Internal => FunctionType::Internal,
7068
Linkage::ExternalWeak => unimplemented!(),
7169
Linkage::Common => unimplemented!(),

compiler/rustc_codegen_llvm/src/base.rs

-1
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,6 @@ pub(crate) fn linkage_to_llvm(linkage: Linkage) -> llvm::Linkage {
157157
Linkage::LinkOnceODR => llvm::Linkage::LinkOnceODRLinkage,
158158
Linkage::WeakAny => llvm::Linkage::WeakAnyLinkage,
159159
Linkage::WeakODR => llvm::Linkage::WeakODRLinkage,
160-
Linkage::Appending => llvm::Linkage::AppendingLinkage,
161160
Linkage::Internal => llvm::Linkage::InternalLinkage,
162161
Linkage::ExternalWeak => llvm::Linkage::ExternalWeakLinkage,
163162
Linkage::Common => llvm::Linkage::CommonLinkage,

compiler/rustc_codegen_ssa/src/codegen_attrs.rs

-1
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,6 @@ fn linkage_by_name(tcx: TyCtxt<'_>, def_id: LocalDefId, name: &str) -> Linkage {
4141
// ghost, dllimport, dllexport and linkonce_odr_autohide are not supported
4242
// and don't have to be, LLVM treats them as no-ops.
4343
match name {
44-
"appending" => Appending,
4544
"available_externally" => AvailableExternally,
4645
"common" => Common,
4746
"extern_weak" => ExternalWeak,

compiler/rustc_codegen_ssa/src/mir/naked_asm.rs

-1
Original file line numberDiff line numberDiff line change
@@ -190,7 +190,6 @@ fn prefix_and_suffix<'tcx>(
190190
Linkage::Internal => {
191191
// write nothing
192192
}
193-
Linkage::Appending => emit_fatal("Only global variables can have appending linkage!"),
194193
Linkage::Common => emit_fatal("Functions may not have common linkage"),
195194
Linkage::AvailableExternally => {
196195
// this would make the function equal an extern definition

compiler/rustc_middle/src/mir/mono.rs

-1
Original file line numberDiff line numberDiff line change
@@ -327,7 +327,6 @@ pub enum Linkage {
327327
LinkOnceODR,
328328
WeakAny,
329329
WeakODR,
330-
Appending,
331330
Internal,
332331
ExternalWeak,
333332
Common,

compiler/rustc_monomorphize/src/partitioning.rs

-1
Original file line numberDiff line numberDiff line change
@@ -1238,7 +1238,6 @@ fn collect_and_partition_mono_items(tcx: TyCtxt<'_>, (): ()) -> MonoItemPartitio
12381238
Linkage::LinkOnceODR => "OnceODR",
12391239
Linkage::WeakAny => "WeakAny",
12401240
Linkage::WeakODR => "WeakODR",
1241-
Linkage::Appending => "Appending",
12421241
Linkage::Internal => "Internal",
12431242
Linkage::ExternalWeak => "ExternalWeak",
12441243
Linkage::Common => "Common",

0 commit comments

Comments
 (0)