Skip to content

Commit f7c93c0

Browse files
committed
Auto merge of #38128 - cardoe:req-cmake-only-for-llvm, r=alexcrichton
configure: only req CMake if we're building LLVM CMake is only necessary if LLVM is going to be built and not in any other case. Signed-off-by: Doug Goldstein <[email protected]>
2 parents 0999124 + f83eb40 commit f7c93c0

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

configure

+6-3
Original file line numberDiff line numberDiff line change
@@ -848,7 +848,10 @@ then
848848
fi
849849

850850
# For building LLVM
851-
probe_need CFG_CMAKE cmake
851+
if [ -z "$CFG_LLVM_ROOT" ]
852+
then
853+
probe_need CFG_CMAKE cmake
854+
fi
852855

853856
# On MacOS X, invoking `javac` pops up a dialog if the JDK is not
854857
# installed. Since `javac` is only used if `antlr4` is available,
@@ -1471,7 +1474,7 @@ fi
14711474
step_msg "configuring submodules"
14721475

14731476
# Have to be in the top of src directory for this
1474-
if [ -z $CFG_DISABLE_MANAGE_SUBMODULES ] && [ -z $CFG_ENABLE_RUSTBUILD ]
1477+
if [ -z "$CFG_DISABLE_MANAGE_SUBMODULES" ] && [ -z "$CFG_ENABLE_RUSTBUILD" ]
14751478
then
14761479
cd ${CFG_SRC_DIR}
14771480

@@ -1547,7 +1550,7 @@ do
15471550
then
15481551
msg "not configuring LLVM, rustbuild in use"
15491552
do_reconfigure=0
1550-
elif [ -z $CFG_LLVM_ROOT ]
1553+
elif [ -z "$CFG_LLVM_ROOT" ]
15511554
then
15521555
LLVM_BUILD_DIR=${CFG_BUILD_DIR}$t/llvm
15531556
LLVM_INST_DIR=$LLVM_BUILD_DIR

0 commit comments

Comments
 (0)