Skip to content

Commit f989c1b

Browse files
committed
Include miri, drop cargotest
1 parent c23d548 commit f989c1b

File tree

2 files changed

+19
-15
lines changed

2 files changed

+19
-15
lines changed

src/ci/docker/host-x86_64/x86_64-gnu-tools/checktools.sh

+17-13
Original file line numberDiff line numberDiff line change
@@ -8,24 +8,28 @@ X_PY="$1"
88

99
# Try to test the toolstate-tracked tools and store the build/test success in the TOOLSTATE_FILE.
1010

11-
set +e
12-
python3 "$X_PY" test --stage 2 --no-fail-fast \
13-
src/doc/book \
14-
src/doc/nomicon \
15-
src/doc/reference \
16-
src/doc/rust-by-example \
17-
src/doc/embedded-book \
18-
src/doc/edition-guide \
11+
# Pre-build the compiler and the library first to output a better error message when the build
12+
# itself fails (see https://github.com/rust-lang/rust/issues/127869 for context).
13+
python3 "$X_PY" build --stage 2 compiler rustdoc
1914

20-
set -e
15+
# set +e
16+
# python3 "$X_PY" test --stage 2 --no-fail-fast \
17+
# src/doc/book \
18+
# src/doc/nomicon \
19+
# src/doc/reference \
20+
# src/doc/rust-by-example \
21+
# src/doc/embedded-book \
22+
# src/doc/edition-guide \
23+
24+
# set -e
2125

2226
# debugging: print out the saved toolstates
2327
cat /tmp/toolstate/toolstates.json
24-
28+
#
2529
# Test remaining tools that must pass.
26-
python3 "$X_PY" test --stage 2 check-tools
27-
python3 "$X_PY" test --stage 2 src/tools/clippy
28-
python3 "$X_PY" test --stage 2 src/tools/rustfmt
30+
# python3 "$X_PY" test --stage 2 check-tools
31+
# python3 "$X_PY" test --stage 2 src/tools/clippy
32+
# python3 "$X_PY" test --stage 2 src/tools/rustfmt
2933

3034
# Testing Miri is a bit more complicated.
3135
# We set the GC interval to the shortest possible value (0 would be off) to increase the chance

src/ci/github-actions/jobs.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -82,14 +82,14 @@ envs:
8282
pr:
8383
- image: x86_64-msvc-ext1
8484
env:
85-
SCRIPT: python x.py --stage 2 test src/tools/cargotest src/tools/cargo
85+
SCRIPT: python x.py --stage 2 test src/tools/cargo && src/ci/docker/host-x86_64/x86_64-gnu-tools/checktools.sh x.py /tmp/toolstate/toolstates.json windows
8686
HOST_TARGET: x86_64-pc-windows-msvc
8787
RUST_CONFIGURE_ARGS: --build=x86_64-pc-windows-msvc --enable-lld --save-toolstates=/tmp/toolstate/toolstates.json --set build.cargo=C:/a/rust/rust/cargo.exe
8888
DEPLOY_TOOLSTATES_JSON: toolstates-windows.json
8989
<<: *job-windows-8c
9090
- image: x86_64-msvc-ext2
9191
env:
92-
SCRIPT: python x.py --stage 2 test src/tools/cargotest src/tools/cargo
92+
SCRIPT: python x.py --stage 2 test src/tools/cargo && src/ci/docker/host-x86_64/x86_64-gnu-tools/checktools.sh x.py /tmp/toolstate/toolstates.json windows
9393
HOST_TARGET: x86_64-pc-windows-msvc
9494
RUST_CONFIGURE_ARGS: --build=x86_64-pc-windows-msvc --enable-lld --save-toolstates=/tmp/toolstate/toolstates.json --set build.cargo=C:/a/rust/rust/cargo.exe
9595
DEPLOY_TOOLSTATES_JSON: toolstates-windows.json

0 commit comments

Comments
 (0)