Skip to content

Commit fadc95e

Browse files
committed
Check reachability insead of publicity for fields and inherent impl items
Purely for consistency with other items, it doesn't make any semantic difference
1 parent 34737e3 commit fadc95e

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/librustc_privacy/lib.rs

+2-2
Original file line numberDiff line numberDiff line change
@@ -347,7 +347,7 @@ impl<'a, 'tcx, 'v> Visitor<'v> for EmbargoVisitor<'a, 'tcx> {
347347
if item_level.is_some() {
348348
self.reach().visit_generics(generics);
349349
for field in struct_def.fields() {
350-
if field.node.kind.visibility() == hir::Public {
350+
if self.get(field.node.id).is_some() {
351351
self.reach().visit_struct_field(field);
352352
}
353353
}
@@ -360,7 +360,7 @@ impl<'a, 'tcx, 'v> Visitor<'v> for EmbargoVisitor<'a, 'tcx> {
360360
if item_level.is_some() {
361361
self.reach().visit_generics(generics);
362362
for impl_item in impl_items {
363-
if impl_item.vis == hir::Public {
363+
if self.get(impl_item.id).is_some() {
364364
self.reach().visit_impl_item(impl_item);
365365
}
366366
}

0 commit comments

Comments
 (0)