Skip to content

Commit fb5f020

Browse files
committed
auto merge of #5611 : Kimundi/rust/incoming, r=catamorphism
2 parents 75d615d + df66e8d commit fb5f020

File tree

1 file changed

+15
-2
lines changed

1 file changed

+15
-2
lines changed

src/libcore/str.rs

+15-2
Original file line numberDiff line numberDiff line change
@@ -1865,8 +1865,10 @@ pub struct CharRange {
18651865
* Given a byte position and a str, return the previous char and its position
18661866
*
18671867
* This function can be used to iterate over a unicode string in reverse.
1868+
*
1869+
* returns 0 for next index if called on start index 0
18681870
*/
1869-
fn char_range_at_reverse(ss: &str, start: uint) -> CharRange {
1871+
pub fn char_range_at_reverse(ss: &str, start: uint) -> CharRange {
18701872
let mut prev = start;
18711873

18721874
// while there is a previous byte == 10......
@@ -1875,7 +1877,12 @@ fn char_range_at_reverse(ss: &str, start: uint) -> CharRange {
18751877
}
18761878

18771879
// now refer to the initial byte of previous char
1878-
prev -= 1u;
1880+
if prev > 0u {
1881+
prev -= 1u;
1882+
} else {
1883+
prev = 0u;
1884+
}
1885+
18791886

18801887
let ch = char_at(ss, prev);
18811888
return CharRange {ch:ch, next:prev};
@@ -3761,4 +3768,10 @@ mod tests {
37613768
"12345555".cmp(& &"123456") == Less;
37623769
"22".cmp(& &"1234") == Greater;
37633770
}
3771+
3772+
#[test]
3773+
fn test_char_range_at_reverse_underflow() {
3774+
assert!(char_range_at_reverse("abc", 0).next == 0);
3775+
}
3776+
37643777
}

0 commit comments

Comments
 (0)