Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move tests from tests/rustdoc-ui/ to tests/rustdoc-ui/lints/ where applicable #136501

Open
lolbinarycat opened this issue Feb 3, 2025 · 5 comments
Open

move tests from tests/rustdoc-ui/ to tests/rustdoc-ui/lints/ where applicable #136501

lolbinarycat opened this issue Feb 3, 2025 · 5 comments
Labels
A-technical-debt Area: Internal cleanup work A-testsuite Area: The testsuite used to check the correctness of rustc C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@lolbinarycat
Copy link
Contributor

lolbinarycat commented Feb 3, 2025 •
edited by rustbot
Loading

a few i've spotted just at a glance:

  • unescaped_backticks.rs
  • unportable-markdown.rs

additionally, any tests related to intra-doc links should be moved to the intra-doc directory.
@lolbinarycat lolbinarycat added A-technical-debt Area: Internal cleanup work A-testsuite Area: The testsuite used to check the correctness of rustc C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Feb 3, 2025
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Feb 3, 2025
@yegeunyang
Copy link
Contributor

@rustbot claim

@jieyouxu jieyouxu removed the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Feb 3, 2025
@lolbinarycat
Copy link
Contributor Author

@yegeunyang could you hold off on this until #136400 is merged? otherwise whichever PR isn't merged first will have a bunch of annoying merge conflicts.

@yegeunyang
Copy link
Contributor

@yegeunyang could you hold off on this until #136400 is merged? otherwise whichever PR isn't merged first will have a bunch of annoying merge conflicts.

Of course!

@yegeunyang
Copy link
Contributor

@rustbot release-assignment

@lolbinarycat
Copy link
Contributor Author

additionally, there's several tests involving deref that could get moved to tests/rustdoc/deref.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-technical-debt Area: Internal cleanup work A-testsuite Area: The testsuite used to check the correctness of rustc C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@lolbinarycat @jieyouxu @yegeunyang @rustbot