Skip to content

Test failed in issue-101082.rs: expected string not found in input #139987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
DKLoehr opened this issue Apr 17, 2025 · 5 comments · Fixed by #139989
Closed

Test failed in issue-101082.rs: expected string not found in input #139987

DKLoehr opened this issue Apr 17, 2025 · 5 comments · Fixed by #139989
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc C-bug Category: This is a bug. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@DKLoehr
Copy link

DKLoehr commented Apr 17, 2025

We've started seeing this test failure when trying to package rust for use in chromium (link to build output). The output says

--- stderr -------------------------------
 C:\b\s\w\ir\cache\builder\src\third_party\rust-src\tests\codegen\issues\issue-101082.rs:30:16: error: x86-64-v3: expected string not found in input
  // x86-64-v3: masked.load
...

I see the comment in issue-101082.rs mentions that the test got changed until llvm/llvm-project#134513 got fixed upstream, which happened a few hours ago. Perhaps we need to change the test back now?
@DKLoehr DKLoehr added the C-bug Category: This is a bug. label Apr 17, 2025
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Apr 17, 2025
@jieyouxu
Copy link
Member

cc @cuviper

@cuviper
Copy link
Member

cuviper commented Apr 17, 2025

cc #139430 @scottmcm

Perhaps we need to change the test back now?

We can, but only for sufficiently new LLVM -- I guess you're keeping up with LLVM main?

@DKLoehr
Copy link
Author

DKLoehr commented Apr 17, 2025

Yes, we use the most recent version of both.

@durin42
Copy link
Contributor

durin42 commented Apr 17, 2025

We're also seeing this in our build of LLVM/Rust@HEADs - since the test is already using revisions the easiest thing would be to fork the test into an llvm 20 and an llvm 21+ flavor, but I could also probably make it work by having an x86-64-v3-20 and an x86-64-v3 revision since that seems to be the only difference.

@cuviper would you like me to try one of those?

@cuviper
Copy link
Member

cuviper commented Apr 17, 2025

I think you can just convert the x86-64-v3 part into min-llvm-version: 21 and forget about the masked.load check. That was mostly just so we would notice that it changed (#139430 (comment)), and here we are with the fix! :)

@durin42 durin42 mentioned this issue Apr 17, 2025
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Apr 18, 2025
@matthiaskrgr
Rollup merge of rust-lang#139989 - durin42:llvm-21-issue-101082, r=cu…
1b03b82 
…viper

tests: adjust 101082 test for LLVM 21 fix

Fixes rust-lang#139987.
@jieyouxu jieyouxu added A-testsuite Area: The testsuite used to check the correctness of rustc T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Apr 18, 2025
@bors bors closed this as completed in d3b1674 Apr 18, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Apr 18, 2025
@rust-timer
Unrolled build for rust-lang#139989
fb2f210 
Rollup merge of rust-lang#139989 - durin42:llvm-21-issue-101082, r=cuviper

tests: adjust 101082 test for LLVM 21 fix

Fixes rust-lang#139987.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc C-bug Category: This is a bug. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tests: adjust 101082 test for LLVM 21 fix durin42/rust
5 participants
@durin42 @cuviper @DKLoehr @jieyouxu @rustbot