Skip to content

rustbuild should not grab the latest beta unless instructed to (or on first run) #38532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nrc opened this issue Dec 22, 2016 · 7 comments
Closed
Labels
T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@nrc
Copy link
Member

nrc commented Dec 22, 2016

There is a principle - one should opt-in to a build tool accessing the internet, but also a practical effect - I was in the middle of debugging and my 5 min edit-compile-debug cycle is now an hour because there a new beta got released and now I'm re-compiling llvm :-(

@est31
Copy link
Member

est31 commented Dec 22, 2016

related #37305

@alexcrichton
Copy link
Member

I somewhat disagree with this in the sense that we're doing exactly the same thing as the previous build system, and no one complained about the makefiles...

@sanxiyn sanxiyn added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Dec 31, 2016
@nrc
Copy link
Member Author

nrc commented Jan 4, 2017

@alexcrichton I thought I had to git pull in order to get a new snapshot? Or maybe configure? I don't remember the snapshot changing on a plain make.

@alexcrichton
Copy link
Member

Hm there could perhaps be a bug, but I don't think that "rustbuild downloading stage0 compilers when it thinks it needs to" is a bug. If it thinks it should and it shouldn't then that's a bug.

@nrc
Copy link
Member Author

nrc commented Jan 5, 2017

Nominating for discussion at tools meeting, we can probably talk this through much quicker than in comments

@ranma42
Copy link
Contributor

ranma42 commented Jan 31, 2017

What was the outcome of the discussion?

@alexcrichton
Copy link
Member

This was discussed during the recent tools triage meeting and the conclusion was that the current behavior should be working as intended (pinned betas, not the most recent beta), but if this reproduces again we can investigate!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

No branches or pull requests

5 participants