-
Notifications
You must be signed in to change notification settings - Fork 13.3k
rustbuild should not grab the latest beta unless instructed to (or on first run) #38532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
related #37305 |
I somewhat disagree with this in the sense that we're doing exactly the same thing as the previous build system, and no one complained about the makefiles... |
@alexcrichton I thought I had to |
Hm there could perhaps be a bug, but I don't think that "rustbuild downloading stage0 compilers when it thinks it needs to" is a bug. If it thinks it should and it shouldn't then that's a bug. |
Nominating for discussion at tools meeting, we can probably talk this through much quicker than in comments |
What was the outcome of the discussion? |
This was discussed during the recent tools triage meeting and the conclusion was that the current behavior should be working as intended (pinned betas, not the most recent beta), but if this reproduces again we can investigate! |
There is a principle - one should opt-in to a build tool accessing the internet, but also a practical effect - I was in the middle of debugging and my 5 min edit-compile-debug cycle is now an hour because there a new beta got released and now I'm re-compiling llvm :-(
The text was updated successfully, but these errors were encountered: