Skip to content

Build messages are confusing when build failure is expected for subcomponent. #45541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
virgil-palanciuc opened this issue Oct 26, 2017 · 3 comments
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@virgil-palanciuc
Copy link
Contributor

virgil-palanciuc commented Oct 26, 2017

This is how the current build finishes for me:

   Compiling clippy_lints v0.0.166 (file:///Users/virgilp/Work/rust/OSS/rust/src/tools/clippy/clippy_lints)
error[E0609]: no field `generics` on type `&rustc::hir::MethodSig`
  --> src/tools/clippy/clippy_lints/src/lifetimes.rs:69:58
   |
69 |             check_fn_inner(cx, &sig.decl, Some(id), &sig.generics, item.span);
   |                                                          ^^^^^^^^

error[E0609]: no field `generics` on type `&rustc::hir::MethodSig`
  --> src/tools/clippy/clippy_lints/src/lifetimes.rs:79:54
   |
79 |             check_fn_inner(cx, &sig.decl, body, &sig.generics, item.span);
   |                                                      ^^^^^^^^

error[E0609]: no field `generics` on type `&rustc::hir::MethodSig`
  --> src/tools/clippy/clippy_lints/src/lifetimes.rs:69:58
   |
69 |             check_fn_inner(cx, &sig.decl, Some(id), &sig.generics, item.span);
   |                                                          ^^^^^^^^

error[E0609]: no field `generics` on type `&rustc::hir::MethodSig`
  --> src/tools/clippy/clippy_lints/src/lifetimes.rs:79:54
   |
79 |             check_fn_inner(cx, &sig.decl, body, &sig.generics, item.span);
   |                                                      ^^^^^^^^

error[E0609]: no field `generics` on type `&rustc::hir::MethodSig`
   --> src/tools/clippy/clippy_lints/src/methods.rs:722:84
    |
722 |                    self_kind.matches(first_arg_ty, first_arg, self_ty, false, &sig.generics) {
    |                                                                                    ^^^^^^^^

error[E0609]: no field `generics` on type `&rustc::hir::MethodSig`
   --> src/tools/clippy/clippy_lints/src/methods.rs:722:84
    |
722 |                    self_kind.matches(first_arg_ty, first_arg, self_ty, false, &sig.generics) {
    |                                                                                    ^^^^^^^^

error[E0609]: no field `generics` on type `&rustc::hir::MethodSig`
   --> src/tools/clippy/clippy_lints/src/methods.rs:736:106
    |
736 |                     !self_kinds.iter().any(|k| k.matches(first_arg_ty, first_arg, self_ty, is_copy, &sig.generics)),
    |                                                                                                          ^^^^^^^^

error[E0609]: no field `generics` on type `&rustc::hir::MethodSig`
   --> src/tools/clippy/clippy_lints/src/methods.rs:736:106
    |
736 |                     !self_kinds.iter().any(|k| k.matches(first_arg_ty, first_arg, self_ty, is_copy, &sig.generics)),
    |                                                                                                          ^^^^^^^^

error[E0609]: no field `generics` on type `&rustc::hir::MethodSig`
   --> src/tools/clippy/clippy_lints/src/new_without_default.rs:111:21
    |
111 |             if !sig.generics.ty_params.is_empty() {
    |                     ^^^^^^^^

error[E0609]: no field `generics` on type `&rustc::hir::MethodSig`
   --> src/tools/clippy/clippy_lints/src/new_without_default.rs:111:21
    |
111 |             if !sig.generics.ty_params.is_empty() {
    |                     ^^^^^^^^

error: aborting due to 5 previous errors

error: aborting due to 5 previous errors

error: Could not compile `clippy_lints`.
warning: build failed, waiting for other jobs to finish...
error: Could not compile `clippy_lints`.
warning: build failed, waiting for other jobs to finish...
error: build failed
This failure is expected (see `src/tools/toolstate.toml`)
Build completed successfully in 0:18:03

What's not depicted here is that all the errors are in bold and/or red text, where as the "build completed successfully" is a rather discrete line at the very end - see this screenshot to see what I mean. I spent quite a but of time trying to figure out why the build isn't working on my machine - when in fact it was, actually, working.

@Compro-Prasad
Copy link

This issue is a build failure. Should be fixed as early as possible. I am new to rust and unable to understand what to do about it.

@sinkuu
Copy link
Contributor

sinkuu commented Oct 29, 2017

Clippy maintainer is already working on it. rust-lang/rust-clippy#2140 (comment)

@pietroalbini pietroalbini added C-enhancement Category: An issue proposing an enhancement or a PR with one. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jan 23, 2018
@Dylan-DPC
Copy link
Member

This seems to be no longer an issue. Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

No branches or pull requests

5 participants