Skip to content

impl Debug for Shared and Unique? #46755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
SimonSapin opened this issue Dec 15, 2017 · 1 comment
Closed

impl Debug for Shared and Unique? #46755

SimonSapin opened this issue Dec 15, 2017 · 1 comment

Comments

@SimonSapin
Copy link
Contributor

The Shared and Unique types have #[allow(missing_debug_implementations)]. Is there a reason for this? It seems that an impl like write!(formatter, "Shared({:p})", self.as_ptr()) would be more useful.

CC @rust-lang/libs
@frewsxcv frewsxcv mentioned this issue Dec 17, 2017
Closed
@frewsxcv
Copy link
Member

Opened a PR for this: #46792

frewsxcv added a commit to frewsxcv/rust that referenced this issue Dec 20, 2017
@frewsxcv
Implement Debug for ptr::Shared and ptr::Unique.
82e83c7 
Fixes rust-lang#46755.
@bors bors closed this as completed in ba5d7a6 Jan 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SimonSapin @frewsxcv