Skip to content

regression -- test fails after #46739 that succeeded before it #47674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
remexre opened this issue Jan 23, 2018 · 4 comments
Closed

regression -- test fails after #46739 that succeeded before it #47674

remexre opened this issue Jan 23, 2018 · 4 comments
Labels
C-bug Category: This is a bug. I-crash Issue: The compiler crashes (SIGSEGV, SIGABRT, etc). Use I-ICE instead when the compiler panics. P-high High priority regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@remexre
Copy link
Contributor

remexre commented Jan 23, 2018

remexre/tri@915303d

Note: to build this you need to set DATABASE_URL=tri.db in the environment, and run diesel migration run to create an initial database for diesel_infer_schemas. Yeah, I should stop using that.

Under cargo test --release, this code panics/SIGSEGVs (depending on the nightly) under nightlies after #46739 was merged (according to https://github.com/Mark-Simulacrum/bisect-rust). According to sebk on IRC, it looks like the stack is being overwritten, with the length of the string being set to a value in the "maybe this is signed overflow" range.

An executable for the test that fails as built by 97520cc is at http://www-users.cs.umn.edu/~ringo025/tri-bug/tri-e74526a64d5fbc02
@alexcrichton alexcrichton mentioned this issue Jan 23, 2018
Closed
@alexcrichton
Copy link
Member

Another recent segfault (#47364) also pointes to the same PR using bisect-rust, thanks for the tip and the report @remexre!

@alexcrichton alexcrichton added I-nominated regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 23, 2018
@TimNN TimNN added C-bug Category: This is a bug. I-crash Issue: The compiler crashes (SIGSEGV, SIGABRT, etc). Use I-ICE instead when the compiler panics. labels Jan 23, 2018
@nikomatsakis
Copy link
Contributor

Ought to be fixed by rust-lang/llvm#102

@nikomatsakis
Copy link
Contributor

triage: P-high

Let's check back in once rust-lang/llvm#102 lands.

@rust-highfive rust-highfive added P-high High priority and removed I-nominated labels Jan 25, 2018
@dotdash
Copy link
Contributor

dotdash commented Jan 29, 2018

Works for me using rustc 1.25.0-nightly (21882aad7 2018-01-28) which contains the LLVM upgrade.

@dotdash dotdash closed this as completed Jan 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category: This is a bug. I-crash Issue: The compiler crashes (SIGSEGV, SIGABRT, etc). Use I-ICE instead when the compiler panics. P-high High priority regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@alexcrichton @nikomatsakis @dotdash @TimNN @remexre @rust-highfive