Skip to content

Can we have a bors build that *tests* building outside the rust root dir? #48269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pnkfelix opened this issue Feb 16, 2018 · 1 comment
Closed
Labels
T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Comments

@pnkfelix
Copy link
Member

Supposedly we support bootstrapping rust from directories other than the root of the rust.git checkout.

At least, in the past we have rejected PR's based on the desirability for such support. See for example: #42689 (comment)

But bugs like #48268 nonetheless creep through.

I assert that if we had just one autobuild instance, on our fastest platform (linux?), that tested this scenario, then we could keep developers like me happy (as well as a number of other developers; I'll gather a list if I have to)

@pnkfelix pnkfelix added the T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. label Feb 16, 2018
@Mark-Simulacrum
Copy link
Member

This should effectively be done so long as we don't remove this commit: e78ecd2. Most of our docker images (i.e., Travis) build out of tree in obj dir anyway so they all test building outside root dir. However, only a few pass paths to x.py invocations. Those should test this; I'm going to close as such.

I'm hoping to come up with a better approach to testing rustbuild soon, which will then include something for this too directly in rustbuild. However, for now, I think we can close this as fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

2 participants