Skip to content

miri no longer builds after rust-lang/rust#80905 #80907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rust-highfive opened this issue Jan 11, 2021 · 7 comments · Fixed by #81043
Closed

miri no longer builds after rust-lang/rust#80905 #80907

rust-highfive opened this issue Jan 11, 2021 · 7 comments · Fixed by #81043
Labels
A-miri Area: The miri tool C-bug Category: This is a bug.

Comments

@rust-highfive
Copy link
Contributor

rust-highfive commented Jan 11, 2021

Hello, this is your friendly neighborhood mergebot.
After merging PR #80905, I observed that the tool miri no longer builds.
A follow-up PR to the repository https://github.com/rust-lang/miri is needed to fix the fallout.

cc @JohnTitor, do you think you would have time to do the follow-up work?
If so, that would be great!

@rust-highfive rust-highfive added A-miri Area: The miri tool C-bug Category: This is a bug. labels Jan 11, 2021
@JohnTitor
Copy link
Member

Caused by #80878.

bors added a commit to rust-lang/miri that referenced this issue Jan 11, 2021
@ghost
Copy link

ghost commented Jan 15, 2021

Miri is still not available in latest nightly from rustup. The "rustup" PR has already been merged. Is rust-lang/miri#1670 blocking the submodule update or the submodule update was just forgotten?

@RalfJung
Copy link
Member

The update could be done any time, it just did not seem to be particularly urgent. ;)

@ghost
Copy link

ghost commented Jan 15, 2021

The update could be done any time, it just did not seem to be particularly urgent. ;)

But I think some components being missing from rustup is not good, especially for people like me that use a rust-toolchain file, update it from time to time and gate CI on Miri.

@oli-obk
Copy link
Contributor

oli-obk commented Jan 15, 2021

that's an orthogonal issue. We are moving away from submodules, at which points tools will never break again, but it takes a bit of time. Until then, please be mindful of the available time of all the volunteer contributors. If an update is important to you, you can also open a PR doing a bump yourself.

All the tools are available on beta/stable toolchains, it is only nightly that can have missing tools

@ghost
Copy link

ghost commented Jan 15, 2021

We are moving away from submodules,

Yes, I know you are moving to git subtree.

Until then, please be mindful of the available time of all the volunteer contributors.

As rust-lang/miri#1669 has been merged, I think the update only requires a single git command? I assume there's not too much work, apologize if I'm wrong.

If an update is important to you, you can also open a PR doing a bump yourself.

Yes, I'll do that.
@rustbot claim

@rustbot rustbot assigned ghost and unassigned eddyb, RalfJung and oli-obk Jan 15, 2021
@RalfJung
Copy link
Member

But I think some components being missing from rustup is not good, especially for people like me that use a rust-toolchain file, update it from time to time and gate CI on Miri.

There's a reason the recommended CI setup for Miri has some magic in it to pick a toolchain that contains Miri. :)

Yes, I'll do that.

Thanks! Please r? me in the PR.

@ghost ghost mentioned this issue Jan 15, 2021
@bors bors closed this as completed in bc39d4d Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-miri Area: The miri tool C-bug Category: This is a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants