-
Notifications
You must be signed in to change notification settings - Fork 13.3k
miri
no longer builds after rust-lang/rust#80905
#80907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Caused by #80878. |
Miri is still not available in latest nightly from rustup. The "rustup" PR has already been merged. Is rust-lang/miri#1670 blocking the submodule update or the submodule update was just forgotten? |
The update could be done any time, it just did not seem to be particularly urgent. ;) |
But I think some components being missing from rustup is not good, especially for people like me that use a |
that's an orthogonal issue. We are moving away from submodules, at which points tools will never break again, but it takes a bit of time. Until then, please be mindful of the available time of all the volunteer contributors. If an update is important to you, you can also open a PR doing a bump yourself. All the tools are available on beta/stable toolchains, it is only nightly that can have missing tools |
Yes, I know you are moving to
As rust-lang/miri#1669 has been merged, I think the update only requires a single git command? I assume there's not too much work, apologize if I'm wrong.
Yes, I'll do that. |
There's a reason the recommended CI setup for Miri has some magic in it to pick a toolchain that contains Miri. :)
Thanks! Please |
Hello, this is your friendly neighborhood mergebot.
After merging PR #80905, I observed that the tool miri no longer builds.
A follow-up PR to the repository https://github.com/rust-lang/miri is needed to fix the fallout.
cc @JohnTitor, do you think you would have time to do the follow-up work?
If so, that would be great!
The text was updated successfully, but these errors were encountered: