Skip to content

rustdoc: Add missing IDs to ID map #91758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
camelid opened this issue Dec 10, 2021 · 1 comment
Open

rustdoc: Add missing IDs to ID map #91758

camelid opened this issue Dec 10, 2021 · 1 comment
Labels
A-rustdoc-ui Area: Rustdoc UI (generated HTML) C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@camelid
Copy link
Member

camelid commented Dec 10, 2021 •
edited by jsha
Loading

In src/librustdoc/html/render/mod.rs, the print_entries function generates <h3 id="{}">.... The id field comes from a parameter to print_entries, and needs to be unique with respect to other ids in the generated HTML. That means for each call site to print_entries, there is an id we need to add to init_id_map in src/librustdoc/html/markdown.rs.

Originally discussed at: structs and friends
@camelid camelid added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. C-bug Category: This is a bug. A-rustdoc-ui Area: Rustdoc UI (generated HTML) labels Dec 10, 2021
@GuillaumeGomez
Copy link
Member

Once #91759 is fixed, this issue can be closed I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-rustdoc-ui Area: Rustdoc UI (generated HTML) C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@GuillaumeGomez @camelid