From 31e2e91ec82916d1d7e4ac4e14fa8799942a8f05 Mon Sep 17 00:00:00 2001 From: Guillaume Gomez Date: Sat, 24 Sep 2022 14:57:46 +0200 Subject: [PATCH 1/2] Fix color for links in item-info --- src/librustdoc/html/static/css/rustdoc.css | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/librustdoc/html/static/css/rustdoc.css b/src/librustdoc/html/static/css/rustdoc.css index 593c1c436b861..323466e32aacd 100644 --- a/src/librustdoc/html/static/css/rustdoc.css +++ b/src/librustdoc/html/static/css/rustdoc.css @@ -1069,6 +1069,10 @@ so that we can apply CSS-filters to change the arrow color in themes */ font-weight: normal; } +.stab a { + color: inherit; +} + .stab .emoji { font-size: 1.25rem; margin-right: 0.3rem; From 23e957d78043a41ccdb27393544ecd46e64bb622 Mon Sep 17 00:00:00 2001 From: Guillaume Gomez Date: Sat, 24 Sep 2022 15:17:50 +0200 Subject: [PATCH 2/2] Add GUI tests for item-info colors --- src/test/rustdoc-gui/item-info.goml | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+) diff --git a/src/test/rustdoc-gui/item-info.goml b/src/test/rustdoc-gui/item-info.goml index 8750d5c53606f..06a784a7d3c29 100644 --- a/src/test/rustdoc-gui/item-info.goml +++ b/src/test/rustdoc-gui/item-info.goml @@ -30,3 +30,29 @@ compare-elements-css: ( "#main-content > .item-info .stab:nth-of-type(2)", ["height"], ) + +// Now checking the text color and the links color. +show-text: true +local-storage: {"rustdoc-theme": "dark", "rustdoc-use-system-theme": "false"} +goto: file://|DOC_PATH|/lib2/trait.Trait.html + +assert-css: (".item-info .stab", {"color": "rgb(221, 221, 221)"}, ALL) +assert-css: (".item-info .stab strong", {"color": "rgb(221, 221, 221)"}, ALL) +assert-css: (".item-info .stab span", {"color": "rgb(221, 221, 221)"}, ALL) +assert-css: (".item-info .stab a", {"color": "rgb(221, 221, 221)"}, ALL) + +local-storage: {"rustdoc-theme": "ayu"} +reload: + +assert-css: (".item-info .stab", {"color": "rgb(197, 197, 197)"}, ALL) +assert-css: (".item-info .stab strong", {"color": "rgb(197, 197, 197)"}, ALL) +assert-css: (".item-info .stab span", {"color": "rgb(197, 197, 197)"}, ALL) +assert-css: (".item-info .stab a", {"color": "rgb(197, 197, 197)"}, ALL) + +local-storage: {"rustdoc-theme": "light"} +reload: + +assert-css: (".item-info .stab", {"color": "rgb(0, 0, 0)"}, ALL) +assert-css: (".item-info .stab strong", {"color": "rgb(0, 0, 0)"}, ALL) +assert-css: (".item-info .stab span", {"color": "rgb(0, 0, 0)"}, ALL) +assert-css: (".item-info .stab a", {"color": "rgb(0, 0, 0)"}, ALL)