Skip to content

Incremental build on Windows #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hcs64 opened this issue Aug 24, 2018 · 7 comments
Closed

Incremental build on Windows #187

hcs64 opened this issue Aug 24, 2018 · 7 comments
Labels
E-easy Difficulty: might be a good place for a beginner E-help-wanted Call for participation: extra help is wanted E-needs-writeup Call for participation: discussion can be written up without much research required

Comments

@hcs64
Copy link

hcs64 commented Aug 24, 2018

I've been trying the instructions at how-to-build-and-run.md with MSYS2 set up as in the main Rust readme, but at link time I get an "ordinal too large" error. I have been able to make more progress by removing the -i for incremental build from ./x.py build -i --stage 1 src/libstd, this might be worth a brief mention.

(I'm not sure if that's the only change needed, I removed the config.toml customizations unsuccessfully before trying this route, I'll follow up once I can start another build from scratch.)

@mark-i-m
Copy link
Member

@retep998 have you seen this error before? Any thoughts?

@retep998
Copy link
Member

This is the first time I've heard about this specific issue. A similar issue I have seen is for pc-windows-msvc where people are running into LINK : fatal error LNK1189: library limit of 65535 objects exceeded because incremental and codegen units split up everything into so many object files that it exceeds limits in the linker. I don't know if they're the same issue, but it would be worth someone investigating the limits of both of those linkers.

@mark-i-m
Copy link
Member

Hmm... Perhaps it would be good to open an issue on rust-lang/rust?

@hcs64 would you mind doing that and linking to this issue?

@hcs64
Copy link
Author

hcs64 commented Aug 30, 2018

There's already rust-lang/rust#53014, so I'll just mention there it happens with pc-windows-gnu as well.

I'd brought it up here because this doc suggests -i and it'd have saved some time to avoid on Windows.

@mark-i-m
Copy link
Member

mark-i-m commented Sep 5, 2018

Hmm i see what you mean. We should add a note with a link to this post where it suggests -i. Would you mind opening a PR?

@mark-i-m mark-i-m added E-help-wanted Call for participation: extra help is wanted E-easy Difficulty: might be a good place for a beginner labels Oct 13, 2018
@mark-i-m mark-i-m added the E-needs-writeup Call for participation: discussion can be written up without much research required label May 6, 2020
@jyn514
Copy link
Member

jyn514 commented Apr 3, 2021

rust-lang/rust#53014 has been closed - does this issue need to stay open? I think there are a fair number of compiler contributors using incremental on windows.

@jyn514 jyn514 closed this as completed Apr 3, 2021
@jyn514 jyn514 reopened this Apr 3, 2021
@rylev
Copy link
Member

rylev commented Apr 14, 2021

Going to close this because I've not heard of this issue. Windows with MSVC is my main driver and I've not run into issues. We can reopen if others have issues.

@rylev rylev closed this as completed Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E-easy Difficulty: might be a good place for a beginner E-help-wanted Call for participation: extra help is wanted E-needs-writeup Call for participation: discussion can be written up without much research required
Projects
None yet
Development

No branches or pull requests

5 participants