Skip to content

Perf summaries ignore max-rss #988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jyn514 opened this issue Aug 31, 2021 · 1 comment
Closed

Perf summaries ignore max-rss #988

jyn514 opened this issue Aug 31, 2021 · 1 comment
Labels
C-feature-request A feature request

Comments

@jyn514
Copy link
Member

jyn514 commented Aug 31, 2021

Max-rss has historically been noisy for rustc, but it's been quite accurate for rustdoc. rust-lang/rust#88522 (comment) says "Summary: This benchmark run did not return any relevant changes.", but the max-rss measurement shows a consistent 1% improvement on -doc runs. It would be great for the summary to reflect that.

(This could be a duplicate of #980, but I suspect you went with just instruction count for the summaries while implementing the prototype.)
@rylev rylev added the C-feature-request A feature request label Sep 1, 2021
@Kobzol
Copy link
Contributor

Kobzol commented Aug 25, 2022

The PR summary comments now include Max RSS (and also cycles) in addition to instruction counts.

@Kobzol Kobzol closed this as completed Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-feature-request A feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rylev @Kobzol @jyn514