Address review feedback

killercup · killercup · commit 2eaaa757d2ee · 2018-05-23T16:43:47.000+02:00
diff --git a/cargo-fix/tests/all/edition_upgrade.rs b/cargo-fix/tests/all/edition_upgrade.rs
@@ -72,7 +72,6 @@ fn local_paths() {
 [FINISHED] dev [unoptimized + debuginfo]
 ";
     p.expect_cmd("cargo-fix fix --prepare-for 2018")
-        .env("__CARGO_FIX_YOLO", "true")
         .stdout("")
         .stderr(stderr)
         .run();
@@ -105,7 +104,6 @@ fn local_paths_no_fix() {
 [FINISHED] dev [unoptimized + debuginfo]
 ";
     p.expect_cmd("cargo-fix fix --prepare-for 2018")
-        .env("__CARGO_FIX_YOLO", "true")
         .stdout("")
         .stderr(stderr)
         .run();
diff --git a/src/lib.rs b/src/lib.rs
@@ -183,7 +183,7 @@ pub fn collect_suggestions<S: ::std::hash::BuildHasher>(
                     match (filter, &span.suggestion_applicability) {
                         (MachineApplicableOnly, Some(MachineApplicable)) => true,
                         (MachineApplicableOnly, _) => false,
-                        (_, _) => true,
+                        (Everything, _) => true,
                     }
                 })
                 .filter_map(collect_span)

Original file line number	Diff line number	Diff line change
`@@ -183,7 +183,7 @@ pub fn collect_suggestions<S: ::std::hash::BuildHasher>(`
`183`	`183`	`match (filter, &span.suggestion_applicability) {`
`184`	`184`	`(MachineApplicableOnly, Some(MachineApplicable)) => true,`
`185`	`185`	`(MachineApplicableOnly, _) => false,`
`186`		`- (_, _) => true,`
	`186`	`+ (Everything, _) => true,`
`187`	`187`	`}`
`188`	`188`	`})`
`189`	`189`	`.filter_map(collect_span)`