Skip to content
This repository was archived by the owner on Nov 24, 2023. It is now read-only.

Detect overlapping fixes and identical fixes #57

Closed
3 tasks done
Manishearth opened this issue Feb 23, 2018 · 3 comments
Closed
3 tasks done

Detect overlapping fixes and identical fixes #57

Manishearth opened this issue Feb 23, 2018 · 3 comments
Labels

Comments

@Manishearth
Copy link
Member

Manishearth commented Feb 23, 2018

If two fixes occur in the same area of text, rustfix will apply both and it will clash.

@killercup
Copy link
Member

Started a quick experiment in https://github.com/killercup/replace-rs for a lib that tracks replacements with their original spans that should be able to catch overlapping fixes. Will try and see if rustfix can easily use something this or if we need more.

(If anyone wants to make this an actually useful and good crate, let me know! I might just move this into rustfix otherwise after fixing some obvious shortcomings.)

@killercup
Copy link
Member

Much happened here, but I think we should still at least add more tests, e.g., to cover macro cases.

(I hope the applicability flag will also help make this more solid)

@killercup
Copy link
Member

The last point was fixed by #131

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants