Review changes

Author: Nick Cameron

Configurations.md

@@ -1243,9 +1243,10 @@ fn adipiscing() -> usize {}
 
 ## `reorder_imports`
 
-Reorder import and extern crate statements alphabetically
+Reorder import and extern crate statements alphabetically in groups (a group is
+separated by a newline).
 
-- **Default value**: `false`
+- **Default value**: `true`
 - **Possible values**: `true`, `false`
 - **Stable**: No
 

src/config/mod.rs

@@ -68,9 +68,9 @@ create_config! {
     imports_layout: ListTactic, ListTactic::Mixed, false, "Item layout inside a import block";
 
     // Ordering
-    reorder_impl_items: bool, false, false, "Reorder impl items";
     reorder_imports: bool, true, false, "Reorder import and extern crate statements alphabetically";
     reorder_modules: bool, true, false, "Reorder module statements alphabetically in group";
+    reorder_impl_items: bool, false, false, "Reorder impl items";
 
     // Spaces around punctuation
     type_punctuation_density: TypeDensity, TypeDensity::Wide, false,

src/reorder.rs

@@ -207,9 +207,9 @@ impl ReorderableItemKind {
 
     pub fn in_group(&self) -> bool {
         match *self {
-            ReorderableItemKind::ExternCrate => true,
-            ReorderableItemKind::Mod => true,
-            ReorderableItemKind::Use => true,
+            ReorderableItemKind::ExternCrate
+            | ReorderableItemKind::Mod
+            | ReorderableItemKind::Use => true,
             ReorderableItemKind::Other => false,
         }
     }