Skip to content

Cross compilation to Windows broken #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Jake-Shadle opened this issue Aug 30, 2021 · 1 comment
Closed

Cross compilation to Windows broken #58

Jake-Shadle opened this issue Aug 30, 2021 · 1 comment

Comments

@Jake-Shadle
Copy link
Contributor

PR #57 broke cross compilation to Windows since it returned to the behavior that assumes that the MSVC toolchain, in particular ml64, is available and can be used.

I can submit a fix for this, would it be ok to add a CI step that tests that cross compilation from Linux works and that the tests run under wine?

@nagisa
Copy link
Member

nagisa commented Aug 30, 2021

Sorry, ml is required for i686-pc-windows-msvc to work at all. This is a much more important use-case I feel and the cross-compilation functionality was breaking rustc (rust-lang/rust#87680). Hence the regression.

Since we have a test for what rustc needs now, I'm happy to accept improvements that add cross-compilation support again in a way that does not break the rustc use-case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants