Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to ndarray 0.14 #109

Closed
relf opened this issue Mar 22, 2021 · 6 comments
Closed

Update to ndarray 0.14 #109

relf opened this issue Mar 22, 2021 · 6 comments

Comments

@relf
Copy link
Member

relf commented Mar 22, 2021

Just to mention I've started to look at using ndarray 0.14 (and hopefully I intend to make a PR in the end)

For now, I am blocked by an issue with sprs which is used by linfa-kernel: sparsemat/sprs#278

@bytesnake
Copy link
Member

thanks for tackling this, last time I looked ndarray-stats still used the old ndarray version

@bytesnake
Copy link
Member

but it isn't anymore, version 0.4.0 is already published on crates.io!

@relf
Copy link
Member Author

relf commented Mar 23, 2021

ah yes! 🤦 what did I check?

@quietlychris
Copy link
Member

@relf As of two days ago (March 25) it actually looks like ndarray has bumped its version up from 0.14 to 0.15. I'm not sure how many breaking chances are actually between the two, but I think if you're planning on updating the version up from 0.13 anyway, it might make sense to jump all the way up (assuming that there's no major issues in the 0.15.0).

@relf
Copy link
Member Author

relf commented Mar 28, 2021

Yep, I haven't dived in but it seems there are more changes from 0.14 to 0.15 than from 0.13 to 0.14.

That said, I think linfa should have at least a minor release for each minor release of ndarray (here we could have linfa 0.4 with ndarray 0.14) because upgrading ndarray is not that easy due to the dependencies.

I do not know how cargo handles several versions of the same crate but I experienced compilation problems when there are various versions of ndarray pulled by various dependencies. And finally I waited for that all dependencies upgraded to ndarray 0.14 before making this PR.

Unfortunately, the sprs issue is blocking right now, and I do not know what is the best course of actions. I picked the revision sparsemat/sprs@761d4f0 where sprs upgraded to ndarray 0.14 to make this PR compile. Should we wait for the issue resolution (which would be the same with ndarray 0.15 anyway) or could we publish a linfa 0.4 based on this?

@relf
Copy link
Member Author

relf commented Apr 22, 2021

fixed by #110

@relf relf closed this as completed Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants