Skip to content

Rename for consistency: sum → sum_axis, scalar_sum → sum. #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
2 tasks done
bluss opened this issue Aug 26, 2017 · 3 comments
Closed
2 tasks done

Rename for consistency: sum → sum_axis, scalar_sum → sum. #346

bluss opened this issue Aug 26, 2017 · 3 comments
Labels
breaking-change

Comments

@bluss
Copy link
Member

bluss commented Aug 26, 2017 •
edited
Loading

I think the sum_axis is a good naming scheme (see map_axis, fold_axis).

  • Add new names sum_axis, mean_axis
  • Rename scalar_sum → sum.
@bluss
Copy link
Member Author

bluss commented Aug 26, 2017

Will use deprecations to the extent possible (not 100% since we swap names)

@bluss
Copy link
Member Author

bluss commented Aug 26, 2017

Only alternative I could see would be to use a more evocative naming like map_across, sum_across?

@bluss bluss mentioned this issue Aug 26, 2017
Merged
@bluss
Copy link
Member Author

bluss commented Nov 21, 2018

Fixed by #520

@bluss bluss closed this as completed Nov 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking-change
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bluss