Skip to content

Commit 2ebe789

Browse files
committed
Add a FIXME comment to the inline(never) and link to the GitHub issue
1 parent 8f5bd4e commit 2ebe789

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

Diff for: bios/stage-4/src/main.rs

+3
Original file line numberDiff line numberDiff line change
@@ -262,6 +262,9 @@ fn detect_rsdp() -> Option<PhysAddr> {
262262
#[derive(Clone)]
263263
struct IdentityMapped;
264264
impl AcpiHandler for IdentityMapped {
265+
// TODO FIXME: This inline(never) annotation is required. Without it,
266+
// LLVM replaces the `search_for_on_bios` call below with a `ud2`
267+
// instruction. See https://github.com/rust-osdev/bootloader/issues/425
265268
#[inline(never)]
266269
unsafe fn map_physical_region<T>(
267270
&self,

0 commit comments

Comments
 (0)