Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary warnings due to inline assembly stabilized in 1.59 #226

Closed
Programatic opened this issue Mar 1, 2022 · 4 comments
Closed

Unnecessary warnings due to inline assembly stabilized in 1.59 #226

Programatic opened this issue Mar 1, 2022 · 4 comments
Labels
v0.9 Affects version 0.9 of the crate

Comments

@Programatic
Copy link

Programatic commented Mar 1, 2022

Hello,

I am getting the following warnings originating from bootloader. As the warning says, in the latest versions inline assembly has been stabilized and thus these feature gates are causing unnecessary clutter in the terminal.

warning: the feature `asm` has been stable since 1.59.0 and no longer requires an attribute to enable
 --> src/main.rs:3:12
  |
3 | #![feature(asm)]
  |            ^^^
  |
  = note: `#[warn(stable_features)]` on by default

warning: the feature `global_asm` has been stable since 1.59.0 and no longer requires an attribute to enable
 --> src/main.rs:2:12
  |
2 | #![feature(global_asm)]
  |    

Edit: I kept confusing the names, sorry :/

@phil-opp phil-opp transferred this issue from rust-osdev/bootimage Mar 1, 2022
@phil-opp phil-opp reopened this Mar 1, 2022
@phil-opp phil-opp added the v0.9 Affects version 0.9 of the crate label Mar 1, 2022
@phil-opp
Copy link
Member

phil-opp commented Mar 1, 2022

Thanks for reporting!

Since you're using bootimage, I assume that you're using a v0.9 release of the bootloader crate. This version does indeed still tries to enable the stabilized asm feature. I'll fix that.

For the v0.10 release, this was fixed in #210, which was released in bootloader v0.10.11. Running cargo update -p bootloader should fix it.

@Programatic
Copy link
Author

Programatic commented Mar 1, 2022

Thanks for the response! I was just following through the series you have on your website, so I assumed that it was not updated yet when I posted this issues, my bad! I tried using v0.10, but couldn't get it working in the few minutes I had spent on it. Is there plans to update the blog to use the newest version, or is this an area that needs help?

@phil-opp
Copy link
Member

phil-opp commented Mar 1, 2022

Yeah, the blog does not work with bootloader v0.10 yet. There were some substantial changes in v0.10 (e.g. UEFI support), so parts of the blog require a rewrite. However, I'm not fully satisfied with the build system of v0.10 yet, so I'm currently working on a new v0.11 version, which I will then use for the next iteration of the blog.

This means that things are in a weird state right now, where both the v0.9 and v0.10 versions of the bootloader crate are actively updated. Sorry for the confusion! I created a PR to fix these warnings in #227.

@phil-opp
Copy link
Member

Fixed in #227

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v0.9 Affects version 0.9 of the crate
Projects
None yet
Development

No branches or pull requests

2 participants