Skip to content

Building error when kernel filename containing special characters #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
midwinter1993 opened this issue Feb 7, 2020 · 3 comments · Fixed by #94
Closed

Building error when kernel filename containing special characters #93

midwinter1993 opened this issue Feb 7, 2020 · 3 comments · Fixed by #94

Comments

@midwinter1993
Copy link

Hi all,

A building error occurs when renaming the kernel binary and building

cp example-kernel/target/x86_64-example-kernel/debug/example-kernel example-kernel/target/x86_64-example-kernel/debug/example-kernel.elf

KERNEL=example-kernel/target/x86_64-example-kernel/debug/example-kernel.elf KERNEL_MANIFEST=example-kernel/Cargo.toml cargo xbuild --release --features binary

Error: rust-lld: error: undefined symbol: _kernel_start_addr.

It seems that build.rs does not redefine the symbols correctly, i.e., _binary_objfile_* set by objcopy, when objfile name contains the special character ..

@phil-opp
Copy link
Member

phil-opp commented Feb 7, 2020

Thanks for reporting this!

I created a fix in #94. Could you verify if it works for you?

@midwinter1993
Copy link
Author

Hi @phil-opp,

Great! It works for me now.

@phil-opp
Copy link
Member

phil-opp commented Feb 8, 2020

Thanks for verifying!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants