Skip to content

Commit f6098f5

Browse files
authored
Merge pull request #1566 from rust-osdev/bishop-mut-pxe
uefi: Consistently use `&mut self` for pxe::BaseCode methods
2 parents 9619d4a + 22604c7 commit f6098f5

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

Diff for: uefi/CHANGELOG.md

+3
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,9 @@
99
- **Breaking:** Removed `BootPolicyError` as `BootPolicy` construction is no
1010
longer fallible. `BootPolicy` now tightly integrates the new `Boolean` type
1111
of `uefi-raw`.
12+
- **Breaking:** The `pxe::BaseCode::tftp_read_dir` and
13+
`pxe::BaseCode::mtftp_read_dir` methods now take `&mut self` instead of
14+
`&self`.
1215
- `boot::memory_map()` will never return `Status::BUFFER_TOO_SMALL` from now on,
1316
as this is considered a hard internal error where users can't do anything
1417
about it anyway. It will panic instead.

Diff for: uefi/src/proto/network/pxe.rs

+2-2
Original file line numberDiff line numberDiff line change
@@ -230,7 +230,7 @@ impl BaseCode {
230230

231231
/// Reads a directory listing of a directory on a TFTP server.
232232
pub fn tftp_read_dir<'a>(
233-
&self,
233+
&mut self,
234234
server_ip: &IpAddress,
235235
directory_name: &CStr8,
236236
buffer: &'a mut [u8],
@@ -363,7 +363,7 @@ impl BaseCode {
363363

364364
/// Reads a directory listing of a directory on a MTFTP server.
365365
pub fn mtftp_read_dir<'a>(
366-
&self,
366+
&mut self,
367367
server_ip: &IpAddress,
368368
buffer: &'a mut [u8],
369369
info: &MtftpInfo,

0 commit comments

Comments
 (0)