- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 169
Evaluate, Discuss + Document role of "alloc" feature in Crate #1303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
So far, the applied approach is unspoken and was never really discussed. "We just did it somehow", mostly. From my point of view, it was a 66.6% prefer non-alloc and a 33.3% do as you like which usually defaults to alloc > non-alloc. |
Making a note from #1528: we also have several types for data allocated internally with UEFI pool memory: |
I think we can close this. Reopen if necessary. TL;DR: Make it alloc-free where easily doable. Otherwise, utilize |
As pointed out in #1297 (comment), we should discuss our strategy regarding the
alloc
feature and its priority when creating user API. This should also be documented, once we discussed and agreed on a strategy.TL;DR: Should we provide interfaces primarily like A, B, or C.
fn get_data(&self) -> Result<Vec<T>>
which is feature-gatedfn get_data(&self, buf: &mut T) -> Result<()>
_in_buffer
or_owned
The text was updated successfully, but these errors were encountered: