Skip to content

Impl TryFrom, From, and Into for VirtAddr #268

Open

Description

@budde25

Hello,

I was wondering if it would be useful to Implement TryFrom, From, and Into for VirtAddr (and maybe other some types as well). I noticed that VirtAddr type specifically has a to_u64. Reading the docs though it seems like the Into trait might be a more idiomatic way to do this.

Another one that might make sense is the TryFrom for u64 and From trait for u32, u16, u8 (the latter would automatically create an Into according to the docs).

If this seems like a worthwhile feature I'd be happy to make pull request.

Fantastic crate btw!

Activity

  1. changed the title [-]Impl `TryFrom`, `From`, and `Into` for VirtAddr[/-] [+]Impl `TryFrom`, `From`, and `Into` for `VirtAddr`[/+] on Jun 15, 2021
  2. josephlr commented on Aug 19, 2021

    @josephlr
    Contributor

    @budde25 this seems reasonable. In #293 (comment) I brainstormed which conversion methods might make sense. PTAL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions